Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong port name in metallb.yml.j2 #8510

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Fix wrong port name in metallb.yml.j2 #8510

merged 1 commit into from
Feb 7, 2022

Conversation

binkoni
Copy link
Contributor

@binkoni binkoni commented Feb 6, 2022 •
edited by oomichi
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
In roles/kubernetes-apps/metallb/templates/metallb.yml.j2
ports for livenessProbe and readinessProbe were assigned wrong
It should be 'monitoring' not 'metrics' according to this pull request from metallb (thanks to @OssenFoss for having found this):
https://github.com/metallb/metallb/pull/1073/files#r756285476

Which issue(s) this PR fixes:

Fixes #8483

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[MetalLB] Fix wrong port name in metallb.yml.j2 (metrics not monitoring)

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2022
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 6, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 6, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @binkoni!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @binkoni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi February 6, 2022 18:06
@LuckySB
Copy link
Contributor

LuckySB commented Feb 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2022
@LuckySB
Copy link
Contributor

LuckySB commented Feb 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: binkoni, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@cristicalin
Copy link
Contributor

Hi @binkoni, please ensure to sing the CLA so this contribution can be accepted.

@binkoni
Copy link
Contributor Author

binkoni commented Feb 7, 2022 •
edited
Loading

"I signed it"

  1. My pull request still doesn't pass!
    If you haven't yet, post a comment ("I signed it") to the PR—this is needed for the system to recheck your contribution > authorization.

@WillsonHG
Copy link

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2022
@binkoni
Copy link
Contributor Author

binkoni commented Feb 7, 2022 •
edited
Loading

Hi @cristicalin could you please check this PR mergable now?
I asked to LFX support and got replied as follows:

_Hi Byeonggon Lee,

The comment #8510 (comment) updated the label on
the PR to cncf-cla: yes, we are currently working on migrating linuxfoundation/cla to EasyCLA, seems the check is not being marked however. Would you please check and confirm if this blocks the PR Merge?

Regards._

If it's still not mergable I will force push my commit

@oomichi
Copy link
Contributor

oomichi commented Feb 7, 2022

Hi @cristicalin could you please check this PR mergable now? I asked to LFX support and got replied as follows:

Hi Byeonggon Lee,
The comment #8510 (comment) updated the label on
the PR to cncf-cla: yes, we are currently working on migrating linuxfoundation/cla to EasyCLA, seems the check is not being marked however. Would you please check and confirm if this blocks the PR Merge?
Regards.

If it's still not mergable I will force push my commit

The tide says Pending — Not mergeable. Needs lgtm label. .
and the change itself seems good for me.
Let's try merging with lgtm label.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@cristicalin
Copy link
Contributor

/check-cla

@cristicalin
Copy link
Contributor

Hmm, you could try force pushing to unblock the CLA check

@k8s-ci-robot k8s-ci-robot merged commit 5695c89 into kubernetes-sigs:master Feb 7, 2022
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Feb 18, 2022
Merge branch 'master' into feature/virtualbox
6fceccf 
* master:
  Configure Etcd container_manager explicitly (kubernetes-sigs#8521)
  Fix print_hostnames of inventory.py (kubernetes-sigs#8554)
  Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550)
  nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539)
  Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530)
  [calico] upgrade release checksums (kubernetes-sigs#8544)
  Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534)
  add support for Dual Stack node InternalIP (kubernetes-sigs#8542)
  terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524)
  add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541)
  implement download mirrors support (kubernetes-sigs#8474)
  Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516)
  feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)
  docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523)
  Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519)
  Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@binkoni @sakuraiyuta
Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
53ee91c
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@binkoni @LuckySB
Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
97bed2e
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 21, 2023
@binkoni @LuckySB
Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
6cd98e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Readiness/Liveness probe errored: strconv.Atoi: parsing "metrics"' on metallb controller & speaker pods
6 participants
@binkoni @k8s-ci-robot @LuckySB @cristicalin @WillsonHG @oomichi