Adding to coredns deployment the nodeselector option #7632

franitel · 2021-05-20T14:02:19Z

What type of PR is this?

kind bug

What this PR does / why we need it:
This PR is to implement the nodeselector to the coredns deployment.
Because if we are using different environments splitted by nodeselector, (production, dev, stage,...) we want to have the option to specify where will be running the coredns pod in our case in production machines.

to see more details, please check:

#7631

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

k8s-ci-robot · 2021-05-20T14:02:21Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-05-20T14:02:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: franitel
To complete the pull request process, please assign chadswen after the PR has been reviewed.
You can assign the PR to them by writing /assign @chadswen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-05-20T14:02:26Z

Welcome @franitel!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-05-20T14:02:26Z

Hi @franitel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oomichi

/cc @oomichi

oomichi · 2021-05-20T18:47:59Z

roles/kubernetes-apps/ansible/defaults/main.yml

@@ -10,6 +10,7 @@ dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas|int > 1 else 'f
 enable_coredns_reverse_dns_lookups: true
 coredns_ordinal_suffix: ""
 # dns_extra_tolerations: [{effect: NoSchedule, operator: "Exists"}]
+# dns_extra_nodeselector


It is necessary to add

dns_extra_nodeselector: {}

to pass test jobs.

@oomichi hello
This is PR already fixing problem with coredns. Need your approve.
Thank a lot

franitel · 2021-05-21T08:02:57Z

/retest

k8s-ci-robot · 2021-05-21T08:03:11Z

@franitel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

franitel · 2021-05-21T08:26:18Z

/test ?

k8s-ci-robot · 2021-05-21T08:26:31Z

@franitel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

franitel · 2021-05-21T08:26:54Z

/test cla/linuxfoundation

k8s-ci-robot · 2021-05-21T08:27:07Z

@franitel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test cla/linuxfoundation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oomichi · 2021-05-21T13:58:21Z

Thanks for updating.
Please follow https://github.com/kubernetes/community/blob/master/CLA.md#the-contributor-license-agreement to pass cla/linuxfoundation check job.

k8s-ci-robot · 2021-05-26T04:14:16Z

@franitel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oomichi · 2021-05-26T16:54:03Z

/check-cla

champtar · 2021-08-11T19:20:28Z

roles/kubernetes-apps/ansible/defaults/main.yml

@@ -10,6 +10,7 @@ dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas|int > 1 else 'f
 enable_coredns_reverse_dns_lookups: true
 coredns_ordinal_suffix: ""
 # dns_extra_tolerations: [{effect: NoSchedule, operator: "Exists"}]
+dns_extra_tolerations: {}


I would name this variable coredns_extra_tolerations

floryut · 2021-09-24T09:37:44Z

@franitel Will close this one if you are not available to update, please don't hesitate to comment/explain/close/rebase ;)

k8s-triage-robot · 2021-12-23T09:40:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-01-22T09:43:39Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

cristicalin · 2022-02-06T07:25:54Z

/close

Please reopen and rebase when you have the time to get back on this topic.

k8s-ci-robot · 2022-02-06T07:26:04Z

@cristicalin: Closed this PR.

In response to this:

/close

Please reopen and rebase when you have the time to get back on this topic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Adding to coredns deployment the nodeselector option

af0dd59

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 20, 2021

k8s-ci-robot requested review from EppO and oomichi May 20, 2021 14:02

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2021

oomichi reviewed May 20, 2021

View reviewed changes

k8s-ci-robot requested a review from oomichi May 20, 2021 18:48

Uncommenting dns_extra_nodeselector variable and adding {}

c6e9691

Removing a white line and adding my proper email to allow do the tests

b7a5693

Francisco José Rodríguez Rubio and others added 2 commits May 24, 2021 08:51

adding option to Without NodeSelector

28bbde1

removing the values because fail some calico tests

5b80f13

franitel force-pushed the master branch from be03c41 to 5b80f13 Compare May 24, 2021 11:05

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2021

champtar reviewed Aug 11, 2021

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 22, 2022

k8s-ci-robot closed this Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding to coredns deployment the nodeselector option #7632

Adding to coredns deployment the nodeselector option #7632

franitel commented May 20, 2021 •

edited

Loading

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

oomichi left a comment

oomichi May 20, 2021

efrikin May 24, 2021 •

edited

Loading

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

oomichi commented May 21, 2021

k8s-ci-robot commented May 26, 2021

oomichi commented May 26, 2021

champtar Aug 11, 2021

floryut commented Sep 24, 2021

k8s-triage-robot commented Dec 23, 2021

k8s-triage-robot commented Jan 22, 2022

cristicalin commented Feb 6, 2022

k8s-ci-robot commented Feb 6, 2022

Adding to coredns deployment the nodeselector option #7632

Adding to coredns deployment the nodeselector option #7632

Conversation

franitel commented May 20, 2021 • edited Loading

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

k8s-ci-robot commented May 20, 2021

oomichi left a comment

Choose a reason for hiding this comment

oomichi May 20, 2021

Choose a reason for hiding this comment

efrikin May 24, 2021 • edited Loading

Choose a reason for hiding this comment

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

franitel commented May 21, 2021

k8s-ci-robot commented May 21, 2021

oomichi commented May 21, 2021

k8s-ci-robot commented May 26, 2021

oomichi commented May 26, 2021

champtar Aug 11, 2021

Choose a reason for hiding this comment

floryut commented Sep 24, 2021

k8s-triage-robot commented Dec 23, 2021

k8s-triage-robot commented Jan 22, 2022

cristicalin commented Feb 6, 2022

k8s-ci-robot commented Feb 6, 2022

franitel commented May 20, 2021 •

edited

Loading

efrikin May 24, 2021 •

edited

Loading