Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector for other services and node labels before CNI setup #7613

Merged
merged 1 commit into from
May 25, 2021

Conversation

efrikin
Copy link
Contributor

@efrikin efrikin commented May 13, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Add user-define nodeSelector for calico, calico-node-controllers, coredns, dns-autoscaler, nodelocaldns
  • Add node labels before CNI setup
  • Fix variable name nodelocaldns dns_memory requests to nodelocaldns memory requests

Which issue(s) this PR fixes:

Fixes #7611

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


User-define nodeSelector for calico, calico-node-controllers, coredns, dns-autoscaler, nodelocaldns

action required: Replace, please nodelocaldnsdns_memory_requests to nodelocaldns_memory_requests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi May 13, 2021 13:39
@k8s-ci-robot
Copy link
Contributor

Welcome @efrikin!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @efrikin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2021
@efrikin efrikin changed the title Add nodeSelctor for other services and node labels before CNI setup Add nodeSelector for other services and node labels before CNI setup May 13, 2021
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/ansible/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes-apps/ansible/defaults/main.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 13, 2021 17:15
@efrikin efrikin force-pushed the add_nodeselectors branch from ac4bc01 to 0a8bd1f Compare May 13, 2021 18:26
@oomichi
Copy link
Contributor

oomichi commented May 13, 2021

Thanks for updating.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021
@oomichi
Copy link
Contributor

oomichi commented May 24, 2021

/cc @floryut

@k8s-ci-robot k8s-ci-robot requested a review from floryut May 24, 2021 22:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efrikin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7db76f8 into kubernetes-sigs:master May 25, 2021
@efrikin efrikin deleted the add_nodeselectors branch June 2, 2021 08:07
@efrikin efrikin restored the add_nodeselectors branch June 2, 2021 08:07
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 17, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nodeSelector for calico, coredns and others services
4 participants