Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreDNS pods running at every node. (Nodeselector.) #7631

Closed
franitel opened this issue May 20, 2021 · 6 comments
Closed

CoreDNS pods running at every node. (Nodeselector.) #7631

franitel opened this issue May 20, 2021 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@franitel
Copy link

Environment:

  • *Kubernetes on premises with more than 50 servers.
    We are running using several environments separated by nodeselector.

The issue is that we have several environment and each environment is using different kind of machines, some for production
some for testing purpose, some for dev, staging,... and we have detected that we have some coredns pods running on test machines then we want to keep these important pods in production.

nodeSelector:
  node.kubernetes.io/environment: "production"

then I was checking the kubespray playbook the last version and I saw that it is hardcoded in the coredns-deployment.yml.j2 file:

https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/ansible/templates/coredns-deployment.yml.j2

image

a Proposal in how to solve the issue is to do the same that we have in the dns_extra_tolerations

image

create a variable in
https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/ansible/defaults/main.yml

to allow specify the NodeSelector to this coredns-deployment.

Tell me if you need more details and thanks for your great job!!

Francisco Rodriguez

@franitel franitel added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2021
@floryut
Copy link
Member

floryut commented May 20, 2021

@franitel Don't hesitate to create a PR 😄

@bac-w
Copy link
Contributor

bac-w commented May 22, 2021

it works like this for me
Without NodeSelector
dns_extra_tolerations: [{effect: NoExecute, key: "node-role.kubernetes.io/node"}]

@efrikin
Copy link
Contributor

efrikin commented May 27, 2021

@franitel It PR already fixed your problem

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2021
@franitel
Copy link
Author

I closed this issue because already was resolved in other issue.
#7613
BR,
Francisco Rodriguez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants