Fix broken Octavia integration in OpenStack External Cloud Provider

[qvicksilver]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Because the Octavia Loadbalancer integration breaks without it
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[alijahnas]

Hi @qvicksilver
Thanks for the contribution. I tested the octavia integration myself and everything was fine. The octavia was the default load balancer provider. What were the errors that needed this fix?

[qvicksilver]

Hi @qvicksilver
Thanks for the contribution. I tested the octavia integration myself and everything was fine. The octavia was the default load balancer provider. What were the errors that needed this fix?

Without it I got this when creating a LoadBalancer type service:
kube_service_kubernetes_default_kubernetes-lb: error creating loadbalancer {kube_service_kubernetes_default_kubernetes-lb Kubernetes external service default/kubernetes-lb from cluster kubernetes 6d005a6d-6921-4926-9831-6486ded534a7 <nil> amphora []}: Bad request with: [POST https://<redacted>9876/v2.0/lbaas/loadbalancers], error message: {"debuginfo": null, "faultcode": "Client", "faultstring": "Invalid input for field/attribute provider. Value: 'amphora'. Value should be one of: octavia"}

[alijahnas]

I ran through the code of the cloud provider and I think I understand why this is happening: https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/cloudprovider/providers/openstack/openstack.go#L374
Can you please tell me which version of the cloud provider you are using? The default is "latest" which is not great but my bad.
And which version of OpenStack are you running on?
Thanks!

[qvicksilver]

Did not notice before but I'm running "latest" and Queens.

[alijahnas]

I think the problem is that in the latest tag forces the amphora provider. The deployment should work with v1.17.0. In v1.18.0 it changes.
Still you should keep the changes you provided, but can you please add the default tag as v1.18.0 rather than latest in https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/openstack/defaults/main.yml#L15

Thanks

[Miouge1]

This looks good, the "latest" tag can be fixed in a separate issue.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, qvicksilver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miouge1]

/retest