Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assembly fallback_ips and no_proxy var only one time on localhost and… #5957

Merged
merged 5 commits into from
Apr 16, 2020
Merged

assembly fallback_ips and no_proxy var only one time on localhost and… #5957

merged 5 commits into from
Apr 16, 2020

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Apr 14, 2020 •
edited
Loading

… populate result on all hosts

/kind feature

What this PR does / why we need it:
assembly var only one time per all plays, decrease plabook run time

Fixes #5936
Fixes #5927

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@LuckySB LuckySB force-pushed the failback_ips branch 4 times, most recently from 13c9360 to e2b1604 Compare April 14, 2020 18:41
@LuckySB
Copy link
Contributor Author

LuckySB commented Apr 14, 2020

/assign @mattymo

@LuckySB
Copy link
Contributor Author

LuckySB commented Apr 15, 2020

mitogen-hq/mitogen#663

@LuckySB LuckySB changed the title assembly fallback_ips and no_proxy var only one time on localhost and… WIP assembly fallback_ips and no_proxy var only one time on localhost and… Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020
@floryut
Copy link
Member

floryut commented Apr 15, 2020

Sorry @LuckySB cancelled your pipeline because you need to rebase as tests name changed on master

@LuckySB LuckySB force-pushed the failback_ips branch 5 times, most recently from 1f66c8c to 39e76f4 Compare April 15, 2020 23:36
@LuckySB
Copy link
Contributor Author

LuckySB commented Apr 16, 2020 •
edited
Loading

fatal: [kubespray-docker]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'k8s-cluster'\n\nThe error appears to be in '/builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubespray-defaults/tasks/fallback_ips.yml': line 14, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: create fallback_ips_base\n ^ here\n"}

error on line
{% for item in groups['k8s-cluster'] + groups['etcd'] + groups['calico-rr']|default([])|unique %}

because in molecule playbook no inventory with groups!!!

@LuckySB
Copy link
Contributor Author

LuckySB commented Apr 16, 2020

/assign @Miouge1

@LuckySB LuckySB changed the title WIP assembly fallback_ips and no_proxy var only one time on localhost and… assembly fallback_ips and no_proxy var only one time on localhost and… Apr 16, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2020
@Miouge1 Miouge1 added this to the 2.13 milestone Apr 16, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 16, 2020

/lgtm

Looks reasonable

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 35f248d into kubernetes-sigs:master Apr 16, 2020
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Apr 18, 2020
@LuckySB
assembly fallback_ips and no_proxy var only one time on localhost and… (
1c14673 
kubernetes-sigs#5957)

* assembly fallback_ips and no_proxy var only one time on localhost and populate result on all hosts

* add tag always, fix ansible lint errors

* workaround to mitogen issue mitogen-hq/mitogen#663

* do not gather fact before install python on coreos like distros

* try to pass docker molecule test
@LuckySB LuckySB mentioned this pull request Apr 23, 2020
Closed
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
@alexkross alexkross mentioned this pull request Apr 24, 2020
Closed
spaced pushed a commit to spaced/kubespray that referenced this pull request Jun 10, 2024
task-14786 Upgrade ingress-controller to 0.35.0
1a03633 
New Features:

NGINX 1.19.2
New configmap option enable-real-ip to enable realip_module
Use k8s.gcr.io vanity domain
Go 1.15
client-go v0.18.6
Migrate to klog v2
Changes:

 kubernetes-sigs#5887 Add force-enable-realip-module
 kubernetes-sigs#5888 Update dev-env.sh script
 kubernetes-sigs#5923 Fix error in grpcbin deployment and enable e2e test
 kubernetes-sigs#5924 Validate endpoints are ready in e2e tests
 kubernetes-sigs#5931 Add opentracing operation name settings
 kubernetes-sigs#5933 Update opentracing nginx module
 kubernetes-sigs#5946 Do not add namespace to cluster-scoped resources
 kubernetes-sigs#5951 Use env expansion to provide namespace in container args
 kubernetes-sigs#5952 Refactor shutdown e2e tests
 kubernetes-sigs#5957 bump fsnotify to v1.4.9
 kubernetes-sigs#5958 Disable enable-access-log-for-default-backend e2e test
 kubernetes-sigs#5984 Fix panic in ingress class validation
 kubernetes-sigs#5986 Migrate to klog v2
 kubernetes-sigs#5987 Fix wait times in e2e tests
 kubernetes-sigs#5990 Fix nginx command env variable reference
 kubernetes-sigs#6004 Update nginx to 1.19.2
 kubernetes-sigs#6006 Update nginx image
 kubernetes-sigs#6007 Update e2e-test-runner image
 kubernetes-sigs#6008 Rollback update of Jaeger library to 0.5.0 and update datadog to 1.2.0
 kubernetes-sigs#6014 Update go dependencies
 kubernetes-sigs#6039 Add configurable serviceMonitor metricRelabelling and targetLabels
 kubernetes-sigs#6046 Add new Dockerfile label org.opencontainers.image.revision
 kubernetes-sigs#6047 Increase wait times in e2e tests
 kubernetes-sigs#6049 Improve docs and logging for --ingress-class usage
 kubernetes-sigs#6052 Fix flaky e2e test
 kubernetes-sigs#6056 Rollback to Poll instead of PollImmediate
 kubernetes-sigs#6062 Adjust e2e timeouts
 kubernetes-sigs#6063 Remove file system paths executables
 kubernetes-sigs#6080 Use k8s.gcr.io vanity domain
@VannTen VannTen mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrlo vrlo vrlo left review comments

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@mattymo mattymo

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.

Add new node using scale.yml fails
6 participants
@LuckySB @k8s-ci-robot @floryut @Miouge1 @vrlo @mattymo