Terraform/OpenStack: Allow free form worker node definition #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/L
|
/approve Looks good to me. Any feedback on this @rguichard and @holmsten ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, qvicksilver The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Apr 18, 2020
…es-sigs#5952) * Terraform/OpenStack: Allow free form worker node definition * fixup! Terraform/OpenStack: Allow free form worker node definition
spaced
pushed a commit
to spaced/kubespray
that referenced
this pull request
Jun 10, 2024
New Features: NGINX 1.19.2 New configmap option enable-real-ip to enable realip_module Use k8s.gcr.io vanity domain Go 1.15 client-go v0.18.6 Migrate to klog v2 Changes: kubernetes-sigs#5887 Add force-enable-realip-module kubernetes-sigs#5888 Update dev-env.sh script kubernetes-sigs#5923 Fix error in grpcbin deployment and enable e2e test kubernetes-sigs#5924 Validate endpoints are ready in e2e tests kubernetes-sigs#5931 Add opentracing operation name settings kubernetes-sigs#5933 Update opentracing nginx module kubernetes-sigs#5946 Do not add namespace to cluster-scoped resources kubernetes-sigs#5951 Use env expansion to provide namespace in container args kubernetes-sigs#5952 Refactor shutdown e2e tests kubernetes-sigs#5957 bump fsnotify to v1.4.9 kubernetes-sigs#5958 Disable enable-access-log-for-default-backend e2e test kubernetes-sigs#5984 Fix panic in ingress class validation kubernetes-sigs#5986 Migrate to klog v2 kubernetes-sigs#5987 Fix wait times in e2e tests kubernetes-sigs#5990 Fix nginx command env variable reference kubernetes-sigs#6004 Update nginx to 1.19.2 kubernetes-sigs#6006 Update nginx image kubernetes-sigs#6007 Update e2e-test-runner image kubernetes-sigs#6008 Rollback update of Jaeger library to 0.5.0 and update datadog to 1.2.0 kubernetes-sigs#6014 Update go dependencies kubernetes-sigs#6039 Add configurable serviceMonitor metricRelabelling and targetLabels kubernetes-sigs#6046 Add new Dockerfile label org.opencontainers.image.revision kubernetes-sigs#6047 Increase wait times in e2e tests kubernetes-sigs#6049 Improve docs and logging for --ingress-class usage kubernetes-sigs#6052 Fix flaky e2e test kubernetes-sigs#6056 Rollback to Poll instead of PollImmediate kubernetes-sigs#6062 Adjust e2e timeouts kubernetes-sigs#6063 Remove file system paths executables kubernetes-sigs#6080 Use k8s.gcr.io vanity domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Enables a free form definition of worker nodes when using Terraform/OpenStack. Currently enabling mixing of node flavors and non uniform worker node configurations. Also since it uses for_each instead of count individual nodes can easily be addressed without Terraform going haywire.
The current mode is limited to one flavor of worker nodes and comes with the drawbacks related to using count for multiplying resources.
Which issue(s) this PR fixes:
Fixes #5458
Special notes for your reviewer:
Does this PR introduce a user-facing change?: