-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring PodNodeSelector via variables #10607
Conversation
Hi @titansmc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It looks like CLA passed now. |
/ok-to-test |
hi @cristicalin or @jayonlau would you mind to review this PR ? |
Thanks @titansmc great works ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @titansmc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, titansmc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows the users to configure the the
clusterDefaultNodeSelector
from the config fileWhich issue(s) this PR fixes:
Fixes #10412
Special notes for your reviewer:
closing #10509 10509