Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring PodNodeSelector via variables #10576

Closed
wants to merge 11 commits into from
Closed

Configuring PodNodeSelector via variables #10576

wants to merge 11 commits into from

Conversation

titansmc
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Allows the users to configure the the clusterDefaultNodeSelector from the config file
Which issue(s) this PR fixes:

Fixes #10412

Special notes for your reviewer:
closing #10509 10509

This will introduce a new variable `kube_apiserver_admission_plugins_podnodeselector_default_node_selector`  that can be used with `kube_apiserver_admission_plugins_needs_configuration: [PodNodeSelector]` defined. So allows the users to configure PodNodeSelector plugin.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2023

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @titansmc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: titansmc
Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@titansmc
Copy link
Contributor Author

Hi, It is a bit annoying that I cannot continue....It seems that the PR itself (when I do it via web interface) is not recognize as my user, look the last entry as it is not like the others:

image

if we cannot fix this, can someone take those changes and make their own PR ?

@floryut
Copy link
Member

floryut commented Oct 31, 2023

Hi, It is a bit annoying that I cannot continue....It seems that the PR itself (when I do it via web interface) is not recognize as my user, look the last entry as it is not like the others:

image

if we cannot fix this, can someone take those changes and make their own PR ?

You don't have access to a git cli somehow ? you only need to rebase your changes

@titansmc
Copy link
Contributor Author

I use the github web interface to create a PR from a forked branch
What do you mean to rebase the changes ?

@titansmc
Copy link
Contributor Author

I am doing everything command line, but the final PR request I do it via github.com , and this PR is also considered a commit and it is where the License agreement fails.

@yankay
Copy link
Member

yankay commented Nov 1, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2023
@titansmc
Copy link
Contributor Author

titansmc commented Nov 3, 2023

/easycla

@titansmc titansmc closed this by deleting the head repository Nov 8, 2023
@titansmc
Copy link
Contributor Author

titansmc commented Nov 8, 2023

it passed the CLA on #10607 @yankay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of kube_apiserver_admission_plugins_needs_configuration not working
4 participants