Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring PodNodeSelector via variables #10509

Closed
wants to merge 2 commits into from
Closed

Configuring PodNodeSelector via variables #10509

wants to merge 2 commits into from

Conversation

titansmc
Copy link
Contributor

@titansmc titansmc commented Oct 9, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Allows the users to configure the the clusterDefaultNodeSelector from the config file
Which issue(s) this PR fixes:

Fixes #10412

Special notes for your reviewer:

This will introduce a new variable `kube_apiserver_admission_plugins_podnodeselector_default_node_selector`  that can be used with `kube_apiserver_admission_plugins_needs_configuration: [PodNodeSelector]` defined. So allows the users to configure PodNodeSelector plugin.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2023

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten October 9, 2023 11:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @titansmc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2023
@titansmc titansmc changed the title new podnodeselector plugin configuration Configuring PodNodeSelector via variables Oct 9, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titansmc Thank you for the PR, can you please check CLA ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, titansmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@titansmc
Copy link
Contributor Author

titansmc commented Oct 9, 2023

@titansmc Thank you for the PR, can you please check CLA ?

There is something wrong with the CLA, once I sign it, it redirects me back to the previous PR #10456

@yankay
Copy link
Member

yankay commented Oct 10, 2023

Thanks @titansmc
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@yankay
Copy link
Member

yankay commented Oct 10, 2023

@titansmc Thank you for the PR, can you please check CLA ?

There is something wrong with the CLA, once I sign it, it redirects me back to the previous PR #10456

I'm not sure how to reslove the problem, but we can try useing the privacy mode in broswer .

@titansmc
Copy link
Contributor Author

@titansmc Thank you for the PR, can you please check CLA ?

There is something wrong with the CLA, once I sign it, it redirects me back to the previous PR #10456

I'm not sure how to reslove the problem, but we can try useing the privacy mode in broswer .

didn't work out...still the same

@yankay
Copy link
Member

yankay commented Oct 12, 2023

@titansmc Thank you for the PR, can you please check CLA ?

There is something wrong with the CLA, once I sign it, it redirects me back to the previous PR #10456

I'm not sure how to reslove the problem, but we can try useing the privacy mode in broswer .

didn't work out...still the same

Hi @titansmc

I have a idea, we can check the CLA at #10456.

And repush commit in the PR, So that the CLA would pass.

@titansmc
Copy link
Contributor Author

@titansmc Thank you for the PR, can you please check CLA ?

There is something wrong with the CLA, once I sign it, it redirects me back to the previous PR #10456

I'm not sure how to reslove the problem, but we can try useing the privacy mode in broswer .

didn't work out...still the same

Hi @titansmc

I have a idea, we can check the CLA at #10456.

And repush commit in the PR, So that the CLA would pass.

I am a bit lost... Although the license was already signed in #10456 and I see no obvious way of checking it again.
Repush commits where ? in which PR ?

@yankay
Copy link
Member

yankay commented Oct 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023
@titansmc titansmc closed this by deleting the head repository Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of kube_apiserver_admission_plugins_needs_configuration not working
4 participants