Check go version #353
Merged
Check go version #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
@fraenkel Thanks for the PR. The repo has two vendors:
For this PR, since the change is under |
fraenkel
added a commit
to fraenkel/kubebuilder
that referenced
this pull request
Aug 12, 2018
droot
reviewed
Aug 14, 2018
| } | ||
| if !c.Check(ver) { | ||
| log.Fatalf("The go version is %v, must be 1.10+", goVersion) | ||
| } |
There was a problem hiding this comment.
Can we abstract the above code into a separate function ?
cmd/kubebuilder/initproject/init.go
Outdated
| log.Fatalf("Could not execute 'go version': %v", err) | ||
| } | ||
|
|
||
| goVersion := strings.TrimPrefix(strings.Split(string(out), " ")[2], "go") |
There was a problem hiding this comment.
We can get invalid index error here.
|
Unrelated TestStorageBee failure |
droot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: fraenkel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jkevlin
pushed a commit
to jkevlin/kubebuilder
that referenced
this pull request
Aug 22, 2018
# This is the 1st commit message: Document adding an external type # This is the commit message kubernetes-sigs#2: Fix typo in book: flag is --owner, not --owners # This is the commit message kubernetes-sigs#3: gitbook: fixed installation instructions # This is the commit message kubernetes-sigs#4: Fix domain resource issues in controller - fix in controller-tools and vendor in kubebuilder - bind resource for controller based on whether resource is created. # This is the commit message kubernetes-sigs#5: improve contributing guide # This is the commit message kubernetes-sigs#6: Fix URL for the Gitbook The URL is .io, not .com # This is the commit message kubernetes-sigs#7: Check go version Fixes kubernetes-sigs#353 # This is the commit message kubernetes-sigs#8: Validate create api flags Fixes kubernetes-sigs#321 # This is the commit message kubernetes-sigs#9: Update stable version in book Update newest stable version to "1.0.1". # This is the commit message kubernetes-sigs#10: thirdparty tools: Dockerfile uses k8s 1.11 # This is the commit message kubernetes-sigs#11: build: update cloudbuild config for building tools to use k8s 1.11 # This is the commit message kubernetes-sigs#12: add document for connecting to existing kind # This is the commit message kubernetes-sigs#13: add document for connecting to existing kind # This is the commit message kubernetes-sigs#14: removed company from doc # This is the commit message kubernetes-sigs#15: fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not allow one to use go from tip which has a version of "devel". Wasn't sure if we want to support this.
When I do a dep ensure, a bunch of changes occur in the root Gopkg.toml and vendor directory. Wasn't sure how it was being managed, but I tried to keep it to a minimal change.