Use StatefulSets for controller-managers and support ShortName for CRD #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
seans3
reviewed
Mar 20, 2018
| r.REST = rt.REST | ||
| r.Strategy = rt.Strategy | ||
| r.ShortName = rt.ShortName | ||
| //r.REST = rt.REST |
There was a problem hiding this comment.
Do you want to check in commented code?
seans3
reviewed
Mar 20, 2018
| if !HasSubresource(c) { | ||
| continue | ||
| } | ||
| //if !HasSubresource(c) { |
seans3
reviewed
Mar 20, 2018
| fmt.Printf("Next: Install the API, run the controller and create an instance with:\n" + | ||
| "$ GOBIN=$(pwd)/bin go install <your-project-go-package>/cmd/controller-manager\n" + | ||
| "$ bin/controller-manager --kubeconfig ~/.kube/config\n" + | ||
| "$ kubectl apply -f hack/sample/" + strings.ToLower(createutil.KindName) + ".yaml\n") |
There was a problem hiding this comment.
The apply example is helpful.
seans3
reviewed
Mar 20, 2018
| Args: []string{"--install-crds=false"}, | ||
| Resources: corev1.ResourceRequirements{ | ||
| Requests: map[corev1.ResourceName]resource.Quantity{ | ||
| "cpu": resource.MustParse("100m"), |
There was a problem hiding this comment.
Should these hard-coded values (e.g. "100m") be more configurable? If not, maybe they can be more descriptive constants (e.g. defaultCpuRequest, defaultCpuLimit).
There was a problem hiding this comment.
This is fine for now. Can ask Ken what reasonable defaults should be. Can use kinflate to override them.
jkevlin
pushed a commit
to jkevlin/kubebuilder
that referenced
this pull request
Aug 22, 2018
# This is the 1st commit message: Document adding an external type # This is the commit message kubernetes-sigs#2: Fix typo in book: flag is --owner, not --owners # This is the commit message kubernetes-sigs#3: gitbook: fixed installation instructions # This is the commit message kubernetes-sigs#4: Fix domain resource issues in controller - fix in controller-tools and vendor in kubebuilder - bind resource for controller based on whether resource is created. # This is the commit message kubernetes-sigs#5: improve contributing guide # This is the commit message kubernetes-sigs#6: Fix URL for the Gitbook The URL is .io, not .com # This is the commit message kubernetes-sigs#7: Check go version Fixes kubernetes-sigs#353 # This is the commit message kubernetes-sigs#8: Validate create api flags Fixes kubernetes-sigs#321 # This is the commit message kubernetes-sigs#9: Update stable version in book Update newest stable version to "1.0.1". # This is the commit message kubernetes-sigs#10: thirdparty tools: Dockerfile uses k8s 1.11 # This is the commit message kubernetes-sigs#11: build: update cloudbuild config for building tools to use k8s 1.11 # This is the commit message kubernetes-sigs#12: add document for connecting to existing kind # This is the commit message kubernetes-sigs#13: add document for connecting to existing kind # This is the commit message kubernetes-sigs#14: removed company from doc # This is the commit message kubernetes-sigs#15: fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.