Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run kubebuilder init with a non-official go release #412

Closed
grantr opened this issue Sep 28, 2018 · 1 comment · Fixed by #445
Closed

Can't run kubebuilder init with a non-official go release #412

grantr opened this issue Sep 28, 2018 · 1 comment · Fixed by #445
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@grantr
Copy link

grantr commented Sep 28, 2018

#353 added a Go version check that bails if it can't parse the version string:

https://github.com/fraenkel/kubebuilder/blob/8a8b76fb4a56c67e4f799fcf035ee22006e3011d/cmd/kubebuilder/initproject/init.go#L136-L139

This makes users with installed go versions like 1.11rc2 completely unable to create kubebuilder projects. I'm not sure if that was the intent or not, but regardless it's a blocker for corporate developers using a custom or mandated golang version.

Since it seems like the purpose of the version check is to ensure that go is at least 1.10, I suggest adding a flag that allows users to skip the go version check and mentioning that flag in the fatal error message:

Couldn't parse Go version '1.11rc2'. Kubebuilder requires at least Go 1.10. You can skip
this check using the --skip-go-version-check flag.
@droot droot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 28, 2018
@AndrewLapin95
Copy link

Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants