improved Go version check #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
droot
force-pushed
the
bugfix/go-version-check-fix
branch
from
80bf75f to
37c064d
Compare
mengqiy
reviewed
Oct 16, 2018
cmd/init_project.go
Outdated
| return fmt.Errorf("invalid version string") | ||
| } | ||
|
|
||
| major, err := strconv.ParseInt(m[1], 10, 64) |
There was a problem hiding this comment.
nit: I guess using strcov.Atoi is OK and easier to understand.
| {"go1.10", false}, | ||
| {"go1.10rc", false}, | ||
| {"go1.10.1", false}, | ||
| {"go1.11rc2", false}, |
There was a problem hiding this comment.
This seems to be a valid RC version, right?
There was a problem hiding this comment.
the flag is inverted :)
droot
force-pushed
the
bugfix/go-version-check-fix
branch
from
37c064d to
b4bc772
Compare
Highlights: - Go version doesn't follow semver style from syntax perspective, so use semver pkg wasn't helpful - re-implemented go version check without using the semver pkg.
droot
force-pushed
the
bugfix/go-version-check-fix
branch
from
b4bc772 to
7b138f1
Compare
|
@mengqiy PTAL. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
use semver pkg wasn't helpful
fixes #412 #439