Allow setting Cloudflare proxying on a per-ingress basis #650

eswets · 2018-07-27T10:07:32Z

The problem

Cloudflare offers the functionality to proxy all traffic through their servers. Currently, this feature can only be enabled globally, causing it to apply for all created records.

The solution

Using annotations, we can override the globally specified proxying option:

external-dns.alpha.kubernetes.io/cloudflare-proxied: "true"

This closes #370

Attribution

This PR was co-created with @amolenaar

k8s-ci-robot · 2018-07-27T10:07:35Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

eswets · 2018-07-27T11:11:17Z

CLA should now be signed by both of us.

njuettner · 2018-08-15T09:41:24Z

/LGTM

shashidharatd · 2018-08-16T12:57:45Z

endpoint/endpoint.go

@@ -107,6 +107,9 @@ func (t Targets) IsLess(o Targets) bool {
 	return false
 }

+// ProviderSpecific is a


Comment is incomplete. Can you please fix it.

shashidharatd · 2018-08-22T14:18:27Z

endpoint/endpoint.go

@@ -107,6 +107,9 @@ func (t Targets) IsLess(o Targets) bool {
 	return false
 }

+// ProviderSpecific holds configuration which is specific to individual DNS providers
+type ProviderSpecific map[string]string


Please reconsider using list of k-v values as per kubernetes api conventions. please refer to this comment for more information #657 (comment)

I'll take a look when I'm back from holidays (end of September)

I've updated the type and updated the CRD docs. Could you take a look specifically if the changes to these docs are correct?

njuettner · 2018-09-21T12:13:52Z

@shashidharatd Do you mind having a look again? 🙂

eswets · 2018-11-12T14:06:56Z

@shashidharatd Any chance you could take a look? 🙏

shashidharatd

@eswets, apologies, somehow i missed earlier notifications.
except the following comment, this lgtm. Also please do re-organize the commits to exclude commits like fixed comments etc.. Thanks!

shashidharatd · 2018-11-13T06:00:13Z

endpoint/endpoint.go

+// ProviderSpecificProperty holds the name and value of a configuration which is specific to individual DNS providers
+type ProviderSpecificProperty struct {
+	Name  string
+	Value string


missing json tags

njuettner · 2018-11-15T09:14:04Z

@eswets sorry again for taking so long to merge this PR, do you mind rebase from the master again to solve the conflicting files?

eswets · 2018-11-16T12:40:41Z

That should be all!

unix-way · 2018-12-18T11:28:54Z

A change to an existing external-dns.alpha.kubernetes.io/cloudflare-proxied annotation does not cause a DNS record update, though it successfully triggers the generation of a new endpoint with the set provider-specific property. So the only two ways to toggle the proxy-mode after changing the annotation are to recreate a record or to do it manually. Was it done intentionally?

materemias · 2019-01-02T01:59:19Z

Is there anything left to be done with this, or only a lgtm is missing?

eswets · 2019-01-02T12:17:25Z

I'll take a look at the feedback from @unix-way tonight, as this behaviour is not intended. Having said that, I would like to have this merged to prevent having to fix all merge conflicts again.

freddd · 2019-01-10T11:32:17Z

@eswets we are looking forward to this being merged as we recently started migrating some stuff to cloudflare. Did you find any blockers or is it ready to be merged? We really appreciate you taking the time to create the PR 👍

wingZero21 · 2019-01-11T10:58:55Z

Hi,

We are also looking at using Cloudflare in the future for this so it would be great if this could be pulled in to give us the option to specify the proxy is on where required.

Cheers

eswets · 2019-01-11T19:24:45Z

I've pushed a fix for supporting updates to the external-dns.alpha.kubernetes.io/cloudflare-proxied annotation. I also did an end-to-end test with CloudFlare, and all works as expected now. So nothing is blocking a merge now as far as i can see.

materemias · 2019-01-26T22:47:41Z

@njuettner can this be merged?

njuettner · 2019-01-28T10:14:21Z

/lgtm

njuettner · 2019-01-28T10:14:28Z

/approve

k8s-ci-robot · 2019-01-28T10:14:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add favicon to docs * Use svg * Add relURL

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 27, 2018

njuettner self-assigned this Aug 6, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2018

njuettner mentioned this pull request Aug 16, 2018

CRD source based on getting endpoints from CRD #657

Merged

shashidharatd reviewed Aug 16, 2018

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018

shashidharatd reviewed Aug 22, 2018

View reviewed changes

njuettner mentioned this pull request Sep 14, 2018

OpenStack Designate provider: failure to update existing recordset #603

Closed

dzoeteman mentioned this pull request Sep 16, 2018

WIP: Specify AWS zone type per service/ingress #454

Closed

shashidharatd reviewed Nov 13, 2018

View reviewed changes

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2018

Allow setting Cloudflare proxying by annotation

e0e7a9d

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2018

materemias mentioned this pull request Dec 19, 2018

[stable/external-dns] add an option to enable Cloudflare proxy (DDOS protection, CDN...) helm/charts#10141

Merged

3 tasks

mattparkes mentioned this pull request Dec 20, 2018

Ability to set cloudflare-proxied by annotation #370

Closed

Support updating ProviderSpecific property.

a5441bd

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2019

njuettner and others added 3 commits January 24, 2019 11:16

Merge branch 'master' into cloudflare-proxied-annotation

6d39526

Update Gopkg.toml

18b343e

Update Gopkg.toml

a8b127a

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019

k8s-ci-robot merged commit 49afe00 into kubernetes-sigs:master Jan 28, 2019

This was referenced Jan 29, 2019

Correctly set AWS annotation for EvaluateTargetHealth #877

Closed

Performance regression with the AWS provider in 0.5.9 #869

Closed

Ignore AWS EvaluateTargetHealth when detecting plan changes #880

Merged

alexanderbuhler mentioned this pull request Mar 22, 2019

Cloudflare proxied annotation broken? #940

Closed

lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022

Add favicon (kubernetes-sigs#650)

3ce4e23

* Add favicon to docs * Use svg * Add relURL

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow setting Cloudflare proxying on a per-ingress basis #650

Allow setting Cloudflare proxying on a per-ingress basis #650

eswets commented Jul 27, 2018

k8s-ci-robot commented Jul 27, 2018

eswets commented Jul 27, 2018

njuettner commented Aug 15, 2018

shashidharatd Aug 16, 2018

eswets Aug 16, 2018

shashidharatd Aug 22, 2018

eswets Aug 28, 2018

eswets Sep 21, 2018

njuettner commented Sep 21, 2018

eswets commented Nov 12, 2018

shashidharatd left a comment

shashidharatd Nov 13, 2018

njuettner commented Nov 15, 2018

eswets commented Nov 16, 2018

unix-way commented Dec 18, 2018 •

edited

Loading

materemias commented Jan 2, 2019

eswets commented Jan 2, 2019

freddd commented Jan 10, 2019

wingZero21 commented Jan 11, 2019

eswets commented Jan 11, 2019

materemias commented Jan 26, 2019

njuettner commented Jan 28, 2019

njuettner commented Jan 28, 2019

k8s-ci-robot commented Jan 28, 2019

Allow setting Cloudflare proxying on a per-ingress basis #650

Allow setting Cloudflare proxying on a per-ingress basis #650

Conversation

eswets commented Jul 27, 2018

The problem

The solution

Attribution

k8s-ci-robot commented Jul 27, 2018

eswets commented Jul 27, 2018

njuettner commented Aug 15, 2018

shashidharatd Aug 16, 2018

Choose a reason for hiding this comment

eswets Aug 16, 2018

Choose a reason for hiding this comment

shashidharatd Aug 22, 2018

Choose a reason for hiding this comment

eswets Aug 28, 2018

Choose a reason for hiding this comment

eswets Sep 21, 2018

Choose a reason for hiding this comment

njuettner commented Sep 21, 2018

eswets commented Nov 12, 2018

shashidharatd left a comment

Choose a reason for hiding this comment

shashidharatd Nov 13, 2018

Choose a reason for hiding this comment

njuettner commented Nov 15, 2018

eswets commented Nov 16, 2018

unix-way commented Dec 18, 2018 • edited Loading

materemias commented Jan 2, 2019

eswets commented Jan 2, 2019

freddd commented Jan 10, 2019

wingZero21 commented Jan 11, 2019

eswets commented Jan 11, 2019

materemias commented Jan 26, 2019

njuettner commented Jan 28, 2019

njuettner commented Jan 28, 2019

k8s-ci-robot commented Jan 28, 2019

unix-way commented Dec 18, 2018 •

edited

Loading