CRD source based on getting endpoints from CRD #657

shashidharatd · 2018-08-01T16:54:17Z

This pr will allow one to define a CRD with embedded DNS records (in the form of Endpoints) and then make external-dns to monitor that CRD for Endpoints and rest of the usual magic of programming DNS server continues.

Ref: #555

Here is how to use it.

$ build/external-dns --source crd --crd-source-apiversion multiclusterdns.federation.k8s.io/v1alpha1 --crd-source-kind DNSEndpoint --provider inmemory --once --dry-run
INFO[0000] config: {Master: KubeConfig: Sources:[crd] Namespace: AnnotationFilter: FQDNTemplate: CombineFQDNAndAnnotation:false Compatibility: PublishInternal:false PublishHostIP:false ConnectorSourceServer:localhost:8080 Provider:inmemory GoogleProject: DomainFilter:[] ZoneIDFilter:[] AWSZoneType: AWSAssumeRole: AWSMaxChangeCount:4000 AWSEvaluateTargetHealth:true AzureConfigFile:/etc/kubernetes/azure.json AzureResourceGroup: CloudflareProxied:false InfobloxGridHost: InfobloxWapiPort:443 InfobloxWapiUsername:admin InfobloxWapiPassword: InfobloxWapiVersion:2.3.1 InfobloxSSLVerify:true DynCustomerName: DynUsername: DynPassword: DynMinTTLSeconds:0 OCIConfigFile:/etc/kubernetes/oci.yaml InMemoryZones:[] PDNSServer:http://localhost:8081 PDNSAPIKey: PDNSTLSEnabled:false TLSCA: TLSClientCert: TLSClientCertKey: Policy:sync Registry:txt TXTOwnerID:default TXTPrefix: Interval:1m0s Once:true DryRun:true LogFormat:text MetricsAddress::7979 LogLevel:info TXTCacheInterval:0s ExoscaleEndpoint:https://api.exoscale.ch/dns ExoscaleAPIKey: ExoscaleAPISecret: CRDSourceAPIVersion:multiclusterdns.federation.k8s.io/v1alpha1 CRDSourceKind:DNSEndpoint} 
INFO[0000] running in dry-run mode. No changes to DNS records will be made. 
INFO[0000] Connected to cluster at https://192.168.99.100:8443 
INFO[0000] CREATE: fs1.default.galactic.svc.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.us.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.us1.us.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default" 
INFO[0000] CREATE: fs1.default.galactic.svc.us.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default" 
INFO[0000] CREATE: fs1.default.galactic.svc.us1.us.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default"

/cc @linki @mtsr @pmorie @irfanurrehman

p.s: This pr includes 2 commits from relatively independent pr #655

k8s-ci-robot · 2018-08-01T16:54:19Z

@shashidharatd: GitHub didn't allow me to request PR reviews from the following users: mtsr, irfanurrehman.

Note that only kubernetes-incubator members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This pr will allow one to define a CRD with embedded DNS records (in the form of Endpoints) and then make external-dns to monitor that CRD for Endpoints and rest of the usual magic of programming DNS server continues.

Ref: #555

Here is how to use it.

$ build/external-dns --source generic --generic-source-crd-apiversion multiclusterdns.federation.k8s.io/v1alpha1 --generic-source-crd-kind DNSEndpoint --provider inmemory --once --dry-run
INFO[0000] config: {Master: KubeConfig: Sources:[generic] Namespace: AnnotationFilter: FQDNTemplate: CombineFQDNAndAnnotation:false Compatibility: PublishInternal:false PublishHostIP:false ConnectorSourceServer:localhost:8080 Provider:inmemory GoogleProject: DomainFilter:[] ZoneIDFilter:[] AWSZoneType: AWSAssumeRole: AWSMaxChangeCount:4000 AWSEvaluateTargetHealth:true AzureConfigFile:/etc/kubernetes/azure.json AzureResourceGroup: CloudflareProxied:false InfobloxGridHost: InfobloxWapiPort:443 InfobloxWapiUsername:admin InfobloxWapiPassword: InfobloxWapiVersion:2.3.1 InfobloxSSLVerify:true DynCustomerName: DynUsername: DynPassword: DynMinTTLSeconds:0 OCIConfigFile:/etc/kubernetes/oci.yaml InMemoryZones:[] PDNSServer:http://localhost:8081 PDNSAPIKey: PDNSTLSEnabled:false TLSCA: TLSClientCert: TLSClientCertKey: Policy:sync Registry:txt TXTOwnerID:default TXTPrefix: Interval:1m0s Once:true DryRun:true LogFormat:text MetricsAddress::7979 LogLevel:info TXTCacheInterval:0s ExoscaleEndpoint:https://api.exoscale.ch/dns ExoscaleAPIKey: ExoscaleAPISecret: GenericSourceCRDApiVer:multiclusterdns.federation.k8s.io/v1alpha1 GenericSourceCRDKind:DNSEndpoint} 
INFO[0000] running in dry-run mode. No changes to DNS records will be made. 
INFO[0000] Connected to cluster at https://192.168.99.100:8443 
INFO[0000] CREATE: fs1.default.galactic.svc.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.us.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.us1.us.dzone.io 180 IN A 192.168.99.216 
INFO[0000] CREATE: fs1.default.galactic.svc.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default" 
INFO[0000] CREATE: fs1.default.galactic.svc.us.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default" 
INFO[0000] CREATE: fs1.default.galactic.svc.us1.us.dzone.io 0 IN TXT "heritage=external-dns,external-dns/owner=default"

/cc @linki @mtsr @pmorie @irfanurrehman

p.s: This pr includes 2 commits from relatively independent pr #655

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shashidharatd · 2018-08-06T13:34:42Z

/cc @njuettner, PTAL. Thanks !

pmorie

Very interesting change, left a few comments.

pmorie · 2018-08-08T15:47:59Z

pkg/apis/externaldns/types.go

@@ -185,7 +189,7 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("kubeconfig", "Retrieve target cluster configuration from a Kubernetes configuration file (default: auto-detect)").Default(defaultConfig.KubeConfig).StringVar(&cfg.KubeConfig)

 	// Flags related to processing sources
-	app.Flag("source", "The resource types that are queried for endpoints; specify multiple times for multiple sources (required, options: service, ingress, fake, connector)").Required().PlaceHolder("source").EnumsVar(&cfg.Sources, "service", "ingress", "fake", "connector")
+	app.Flag("source", "The resource types that are queried for endpoints; specify multiple times for multiple sources (required, options: service, ingress, fake, connector)").Required().PlaceHolder("source").EnumsVar(&cfg.Sources, "service", "ingress", "fake", "connector", "generic")


I wonder if crd is a better name here than generic, but I'll leave that question to folks who have more review history than my basically zero in this repo :)

agree, crd source seems better.

pmorie · 2018-08-08T16:01:53Z

pkg/apis/externaldns/types.go

@@ -194,6 +198,8 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("publish-internal-services", "Allow external-dns to publish DNS records for ClusterIP services (optional)").BoolVar(&cfg.PublishInternal)
 	app.Flag("publish-host-ip", "Allow external-dns to publish host-ip for headless services (optional)").BoolVar(&cfg.PublishHostIP)
 	app.Flag("connector-source-server", "The server to connect for connector source, valid only when using connector source").Default(defaultConfig.ConnectorSourceServer).StringVar(&cfg.ConnectorSourceServer)
+	app.Flag("generic-source-crd-apiversion", "Api version of the crd for generic source, format (group/version) valid only when using generic source").Default(defaultConfig.GenericSourceCRDApiVer).StringVar(&cfg.GenericSourceCRDApiVer)


It might be helpful to have an example in the flag description like test.k8s.io/v1alpha1 as you have used in the test.

Suggest also capitalizing API and CRD.

ok, would update.

pmorie · 2018-08-08T16:22:49Z

pkg/apis/externaldns/types.go

@@ -194,6 +198,8 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("publish-internal-services", "Allow external-dns to publish DNS records for ClusterIP services (optional)").BoolVar(&cfg.PublishInternal)
 	app.Flag("publish-host-ip", "Allow external-dns to publish host-ip for headless services (optional)").BoolVar(&cfg.PublishHostIP)
 	app.Flag("connector-source-server", "The server to connect for connector source, valid only when using connector source").Default(defaultConfig.ConnectorSourceServer).StringVar(&cfg.ConnectorSourceServer)
+	app.Flag("generic-source-crd-apiversion", "Api version of the crd for generic source, format (group/version) valid only when using generic source").Default(defaultConfig.GenericSourceCRDApiVer).StringVar(&cfg.GenericSourceCRDApiVer)
+	app.Flag("generic-source-crd-kind", "Kind of the crd for generic source, valid only when using generic source").Default(defaultConfig.GenericSourceCRDKind).StringVar(&cfg.GenericSourceCRDKind)


Suggestion, make the description here: Kind of the CRD for the generic source in API group and version specified by generic-source-crd-apiversion

will update.

pmorie · 2018-08-08T16:43:26Z

source/generic.go

+
+// NewCRDClientForAPIVersionKind return rest client for the given apiVersion and kind of the CRD
+func NewCRDClientForAPIVersionKind(client kubernetes.Interface, kubeConfig, kubeMaster, apiVersion, kind string) (*rest.RESTClient, *runtime.Scheme, error) {
+	if kubeConfig == "" {


Is this the same as using the in-cluster config?

yes, it is almost the same. if user has not set the kubeconfig path explicitly, it would look into standard path $HOME/.kube/config and if that is also not present then uses in-cluster config. I just reused the logic already done by external-dns in here https://github.com/kubernetes-incubator/external-dns/blob/master/source/store.go#L111

pmorie · 2018-08-08T16:55:30Z

endpoint/endpoint.go

+}
+
+// DNSEndpointStatus defines the observed state
+type DNSEndpointStatus struct {


Question: should we have part of the contract between such a CRD and external-dns that external-dns maintains status? We should have observedGeneration here.

This is a good question, and mostly raises another off topic question about optimisation for all the sources in general. currently, all the sources does not seem to be using informer pattern. they just do List the object types from the kube client. It is so because the design of external-dns needs all the objects (providing Endpoint) to feed the planner, which then calculates what changes need to be done in DNS provider.

Coming to this source in particular, it also uses the List operation to get all the CRD objects for now. we could in future write an informer and do a watch, which would give us a local cache of these objects. In that scenario, having such a contract ~~would~~ may be meaningful. Also observedGeneration in status field makes sense for a single CRD object, but here we are dealing with list of such objects, and i am unsure how meaningful that is to maintain it.

Well - the a single instance of this resource is itself a list. I think observedGeneration makes sense as a status field. Otherwise, how do you know - as the controller or the user - that the controller has 'seen' a particular generation of the resource?

@pmorie, currently there is nothing in status, so observedGeneration does not make sense for such an object. It would be unnecessary complexity. wdyt?

@pmorie, now i have added the ObservedGeneration field in the Status according to the discussion. PTAL.

njuettner · 2018-08-16T07:58:30Z

source/crd.go

+
+	config.ContentConfig.GroupVersion = &groupVersion
+	config.APIPath = "/apis"
+	config.ContentType = runtime.ContentTypeJSON


No need to specify the content-type by default it's "application/json"

njuettner · 2018-08-16T08:00:57Z

source/crd.go

+	config.ContentConfig.GroupVersion = &groupVersion
+	config.APIPath = "/apis"
+	config.ContentType = runtime.ContentTypeJSON
+	config.NegotiatedSerializer = serializer.DirectCodecFactory{CodecFactory: serializer.NewCodecFactory(scheme)}


why not using ...{CodeFactory: scheme.Codecs} directly?

i did not find scheme.Codecs in the latest vendored code. Am i missing something.

njuettner · 2018-08-16T08:11:17Z

source/crd.go

+	result := endpoint.DNSEndpointList{}
+	err := cs.crdClient.Get().
+		Namespace(cs.namespace).
+		Resource(strings.ToLower(cs.crdKind)+"s").


Can we somehow make this nicer?

Updated. however not sure what exactly you meant :)

njuettner · 2018-08-16T08:29:11Z

pkg/apis/externaldns/types.go

@@ -142,6 +144,8 @@ var defaultConfig = &Config{
 	ExoscaleEndpoint:         "https://api.exoscale.ch/dns",
 	ExoscaleAPIKey:           "",
 	ExoscaleAPISecret:        "",
+	CRDSourceAPIVersion:      "",


what do you think of externaldns.k8s.io/v1alpha as APIVersion and DNSEndpoint as Kind for default settings?

Agree. Done

njuettner · 2018-08-16T08:29:27Z

pkg/apis/externaldns/types.go

@@ -194,6 +198,8 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("publish-internal-services", "Allow external-dns to publish DNS records for ClusterIP services (optional)").BoolVar(&cfg.PublishInternal)
 	app.Flag("publish-host-ip", "Allow external-dns to publish host-ip for headless services (optional)").BoolVar(&cfg.PublishHostIP)
 	app.Flag("connector-source-server", "The server to connect for connector source, valid only when using connector source").Default(defaultConfig.ConnectorSourceServer).StringVar(&cfg.ConnectorSourceServer)
+	app.Flag("crd-source-apiversion", "API version of the CRD for crd source, e.g. `dns.k8s.io/v1alpha1`, valid only when using crd source").Default(defaultConfig.CRDSourceAPIVersion).StringVar(&cfg.CRDSourceAPIVersion)


dns.k8s.io/v1alpha1 -> externaldns.k8s.io/v1alpha1

njuettner · 2018-08-16T09:03:02Z

endpoint/endpoint.go

 	// Labels stores labels defined for the Endpoint
-	Labels Labels
+	Labels Labels `json:"labels,omitempty"`
 }


There's currently a PR #650 which includes a ProviderSpecific field to set provider specific settings for endpoints.

Could you add it additionally?

njuettner · 2018-08-16T09:29:57Z

Please add some documentation how to use it. This would be really helpful for customers, which like to use CRD.

shashidharatd · 2018-08-16T17:39:10Z

@njuettner, Thanks for your comments. have tried addressing them. Also have added documentation on how to use CRD source. PTAL once again.
Request @pmorie to take a look too. Thanks !

njuettner · 2018-08-17T09:55:39Z

@shashidharatd thank you for adding the documentation.

some notes from my side:

CRD manifest can be also applied manually or for what do I have ? If so can you add it in the documentation, like an example crd.yaml
An example how an object would look like, if I would create via kubectl apply -f dns-example.yaml

shashidharatd · 2018-08-17T13:54:05Z

@njuettner, have added the crd manifest and an example. ptal. Thanks !

njuettner · 2018-08-17T14:12:31Z

👍 for the hard work, thank you! From my point of view it looks good.

I would appreciate if @linki or @ideahitme could have a look again 🙂.

shashidharatd · 2018-08-20T13:59:39Z

Thanks @njuettner, @linki / @ideahitme ptal

pmorie

A couple notes and one question - am I missing something obvious?

pmorie · 2018-08-21T23:32:59Z

docs/contributing/crd-source.md

+
+### Details
+
+CRD source watches for the user specified CRD to extract [Endpoints](https://github.com/kubernetes-incubator/external-dns/blob/master/endpoint/endpoint.go) from its `Spec`.


s/the user/a user/

pmorie · 2018-08-21T23:34:15Z

docs/contributing/crd-source.md

+
+### Creating DNS Records
+
+Create the objects of CRD type by filing in the fields of CRD and DNS record would be created accordingly.


pmorie · 2018-08-21T23:35:39Z

docs/contributing/crd-source.md

+
+### Registering CRD
+
+Here is typical example of CRD which provides Endpoints to `CRD source`:


You should link to the example here so people know that there's an example the rest of this file is in terms of.

pmorie · 2018-08-21T23:37:38Z

endpoint/endpoint.go

@@ -107,18 +109,25 @@ func (t Targets) IsLess(o Targets) bool {
 	return false
 }

+// ProviderSpecific holds configuration which is specific to individual DNS providers
+type ProviderSpecific map[string]string


It's worth considering whether this should be a list of key-value pairs. Maps are supposed to be avoided per the API conventions: https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#lists-of-named-subobjects-preferred-over-maps

I think list of k-v pairs might be better because this is a contract many different types will have to implement.

This field is added by the ongoing pr #650. Its optional for the feature in this pr to work.
I would post the same comments in that pr. In this pr i have just added json tag for it.

pmorie · 2018-08-21T23:38:30Z

endpoint/endpoint.go

+type DNSEndpointStatus struct {
+	// The generation observed by the external-dns controller.
+	// +optional
+	ObservedGeneration int64 `json:"observedGeneration,omitempty"`


pmorie · 2018-08-21T23:39:06Z

endpoint/endpoint.go

+// +genclient
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// DNSEndpoint is the CRD wrapper for Endpoint


I would suggest something like:

// DNSEndpoint is a contract that a user-specified CRD must implement to be used as a source for external-dns.

I would also call out that the user-specified CRD must have the status subresource.

pmorie · 2018-08-21T23:42:26Z

source/crd.go

+		endpoints = append(endpoints, dnsEndpoint.Spec.Endpoints...)
+		dnsEndpoint.Status.ObservedGeneration = dnsEndpoint.Generation
+		// Update the ObservedGeneration
+		_, err = cs.UpdateStatus(&dnsEndpoint)


We should update the observed generation as we do work - it's not clear to me where this method is used. Am I missing something?

Endpoints() is the interface method for Source. The controller calls the Source's Endpoint method and proceeds onto making necessary changes to DNS records in Provider. Source is a interface with just this Endpoints() method.

shashidharatd

@pmorie, have tried addressing your comments. ptal, Thanks !

shashidharatd · 2018-08-22T14:03:18Z

docs/contributing/crd-source.md

+
+### Details
+
+CRD source watches for the user specified CRD to extract [Endpoints](https://github.com/kubernetes-incubator/external-dns/blob/master/endpoint/endpoint.go) from its `Spec`.


shashidharatd · 2018-08-22T14:08:06Z

docs/contributing/crd-source.md

+
+### Registering CRD
+
+Here is typical example of CRD which provides Endpoints to `CRD source`:


shashidharatd · 2018-08-22T14:08:18Z

docs/contributing/crd-source.md

+
+### Creating DNS Records
+
+Create the objects of CRD type by filing in the fields of CRD and DNS record would be created accordingly.


shashidharatd · 2018-08-22T14:10:33Z

endpoint/endpoint.go

@@ -107,18 +109,25 @@ func (t Targets) IsLess(o Targets) bool {
 	return false
 }

+// ProviderSpecific holds configuration which is specific to individual DNS providers
+type ProviderSpecific map[string]string


This field is added by the ongoing pr #650. Its optional for the feature in this pr to work.
I would post the same comments in that pr. In this pr i have just added json tag for it.

shashidharatd · 2018-08-22T14:11:47Z

endpoint/endpoint.go

+// +genclient
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// DNSEndpoint is the CRD wrapper for Endpoint


shashidharatd · 2018-08-22T14:16:38Z

source/crd.go

+		endpoints = append(endpoints, dnsEndpoint.Spec.Endpoints...)
+		dnsEndpoint.Status.ObservedGeneration = dnsEndpoint.Generation
+		// Update the ObservedGeneration
+		_, err = cs.UpdateStatus(&dnsEndpoint)


Endpoints() is the interface method for Source. The controller calls the Source's Endpoint method and proceeds onto making necessary changes to DNS records in Provider. Source is a interface with just this Endpoints() method.

pmorie · 2018-08-28T15:25:36Z

My feedbacks have been addressed, thanks @shashidharatd

pmorie · 2018-09-04T17:25:40Z

@linki @ideahitme We're very interested in getting this merged to use external-dns with federation-v2 - does either of you (or another maintainer) have bandwidth to review this PR?

njuettner · 2018-09-05T12:35:15Z

I think let's merge it now. This seems to be fine and was already reviewed a lot. Thanks again @shashidharatd and @pmorie 👍

shashidharatd · 2018-09-05T13:43:22Z

Thanks @njuettner

2rs2ts · 2018-09-07T20:01:27Z

Is it possible to make latency-based route53 record sets with this feature?

linki · 2018-09-11T15:05:35Z

Is it possible to make latency-based route53 record sets with this feature?

@shashidharatd do you know?

shashidharatd · 2018-09-11T15:15:41Z

Is it possible to make latency-based route53 record sets with this feature?

Honestly, i have no idea. But the Endpoint definition is quite generic, if you can fit in the definition of latency-based route53 record sets inside the Endpoint, then pretty much you can make it.

* Update install.md Add small comment about Windows elevated command prompt * Update install.md More precise description about the symbolic link requirement

k8s-ci-robot requested a review from linki August 1, 2018 16:54

k8s-ci-robot requested a review from pmorie August 1, 2018 16:54

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2018

shashidharatd force-pushed the generic-source branch 2 times, most recently from fdf8414 to 6fb9afc Compare August 6, 2018 13:12

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2018

njuettner self-assigned this Aug 6, 2018

pmorie reviewed Aug 8, 2018

View reviewed changes

shashidharatd force-pushed the generic-source branch from 6fb9afc to a50a306 Compare August 9, 2018 15:25

shashidharatd changed the title ~~Generic source based on getting endpoints from CRD~~ crd source based on getting endpoints from CRD Aug 9, 2018

shashidharatd force-pushed the generic-source branch from a50a306 to 112ba38 Compare August 10, 2018 12:34

njuettner reviewed Aug 16, 2018

View reviewed changes

shashidharatd mentioned this pull request Aug 16, 2018

Make DNS record TTL configurable by user kubernetes-retired/kubefed#207

Merged

shashidharatd force-pushed the generic-source branch from 112ba38 to c4eccb5 Compare August 16, 2018 17:30

shashidharatd force-pushed the generic-source branch from c4eccb5 to bb5401e Compare August 17, 2018 13:52

pmorie reviewed Aug 21, 2018

View reviewed changes

shashidharatd added 7 commits August 22, 2018 19:37

Add wrapper structure for Endpoint in sync with definition of CRD

ddef0a9

Auto generated deepcopy functions for DNSEndpoint CRD

cf11761

Add crd source which gets Endpoints from CRD

18aee82

Add unit tests for crd source

79ad3a8

Add flag specific tests for crd source

3f85526

Fix a possible nil map access

8fd477e

Add documentation for CRD source

1529c02

shashidharatd force-pushed the generic-source branch from bb5401e to 1529c02 Compare August 22, 2018 14:07

shashidharatd mentioned this pull request Aug 22, 2018

Allow setting Cloudflare proxying on a per-ingress basis #650

Merged

shashidharatd commented Aug 22, 2018

View reviewed changes

shashidharatd changed the title ~~crd source based on getting endpoints from CRD~~ CRD source based on getting endpoints from CRD Aug 23, 2018

Merge branch 'master' into generic-source

488f103

njuettner merged commit a7ac4f9 into kubernetes-sigs:master Sep 5, 2018

shashidharatd mentioned this pull request Sep 17, 2018

Add optional ObservedGeneration field to DNSEndpointStatus kubernetes-retired/kubefed#270

Merged

pdf mentioned this pull request Jul 27, 2020

Feature Request: Possibility to create additional (types of) DNS records through CRDs #555

Closed

steve-bitdotio mentioned this pull request Sep 20, 2021

"--crd-source-kind" flag doesn't work as intended #2308

Closed


		### Details

		CRD source watches for the user specified CRD to extract [Endpoints](https://github.com/kubernetes-incubator/external-dns/blob/master/endpoint/endpoint.go) from its `Spec`.


		### Creating DNS Records

		Create the objects of CRD type by filing in the fields of CRD and DNS record would be created accordingly.


		### Registering CRD

		Here is typical example of CRD which provides Endpoints to `CRD source`:

CRD source based on getting endpoints from CRD #657

CRD source based on getting endpoints from CRD #657

Conversation

shashidharatd commented Aug 1, 2018 • edited Loading

k8s-ci-robot commented Aug 1, 2018

shashidharatd commented Aug 6, 2018

pmorie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shashidharatd Aug 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njuettner commented Aug 16, 2018

shashidharatd commented Aug 16, 2018

njuettner commented Aug 17, 2018

shashidharatd commented Aug 17, 2018

njuettner commented Aug 17, 2018

shashidharatd commented Aug 20, 2018

pmorie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shashidharatd Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

shashidharatd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shashidharatd Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

pmorie commented Aug 28, 2018

pmorie commented Sep 4, 2018

njuettner commented Sep 5, 2018 • edited Loading

shashidharatd commented Sep 5, 2018

2rs2ts commented Sep 7, 2018

linki commented Sep 11, 2018 • edited Loading

shashidharatd commented Sep 11, 2018

shashidharatd commented Aug 1, 2018 •

edited

Loading

shashidharatd Aug 9, 2018 •

edited

Loading

shashidharatd Aug 22, 2018 •

edited

Loading

shashidharatd Aug 22, 2018 •

edited

Loading

njuettner commented Sep 5, 2018 •

edited

Loading

linki commented Sep 11, 2018 •

edited

Loading