Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Specify AWS zone type per service/ingress #454

Closed
wants to merge 0 commits into from

Conversation

dzoeteman
Copy link

This PR introduces the ability to specify provider specific annotations in resources (service & ingress implemented), which then can be used to for example filter zones out based on those annotations.

This addition was made based on #423, where it was requested to add a AWS zone type filter per resource.

Note that if a AWS zone type filter is already applied as external-dns flag, this will not use zones that have already been filtered out by that.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2018
@linki
Copy link
Member

linki commented Feb 21, 2018

@dzoeteman Thank you. We'll look at your PR shortly.

@linki linki added this to the v0.6 milestone Apr 23, 2018
@dzoeteman dzoeteman changed the title Specify AWS zone type per service/ingress WIP: Specify AWS zone type per service/ingress Sep 16, 2018
@dzoeteman dzoeteman closed this Sep 16, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2018
@dzoeteman
Copy link
Author

dzoeteman commented Sep 16, 2018

Since master has diverged so much from this PR, I'll re-do it.
Considering #650 adds a lot of the necessary functionality for this to function, I'll wait for that PR to go through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. provider/aws size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants