Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade job should upgrade from 1.20 #1555

Closed
CecileRobertMichon opened this issue Jul 23, 2021 · 10 comments
Closed

Upgrade job should upgrade from 1.20 #1555

CecileRobertMichon opened this issue Jul 23, 2021 · 10 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@CecileRobertMichon
Copy link
Contributor

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-capi-e2e-main is broken since #1524 merged because it's trying to upgrade from 1.19 to 1.21 which is not allowed. We should change the KUBERNETES_VERSION_UPGRADE_FROM variable default
in https://github.com/nader-ziada/cluster-api-provider-azure/blob/08f456963fb47f801e75eae730837e3cffe57bfc/test/e2e/config/azure-dev.yaml to v1.20.9 which is the latest 1.20 patch.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2021
@CecileRobertMichon
Copy link
Contributor Author

/good-first-issue
/help

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 23, 2021
@Rahul-D78
Copy link

/assign

@Rahul-D78
Copy link

hi @CecileRobertMichon can I work on this

@jayesh-srivastava
Copy link
Member

/assign

@CecileRobertMichon
Copy link
Contributor Author

CecileRobertMichon commented Jul 23, 2021

@jayesh-srivastava I'm sorry, it looks like @Rahul-D78 has already assigned themselves this issue

@CecileRobertMichon
Copy link
Contributor Author

/unassign @jayesh-srivastava

@jayesh-srivastava
Copy link
Member

Oh okay, no worries : )

@CecileRobertMichon
Copy link
Contributor Author

/close

@nader-ziada looks like upgrade tests are still failing after your PR https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-capi-e2e-main but we can tackle in a separate issue, closing this one

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

/close

@nader-ziada looks like upgrade tests are still failing after your PR https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-capi-e2e-main but we can tackle in a separate issue, closing this one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants