-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade job should upgrade from 1.20 #1557
Conversation
Hi @Rahul-D78. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test testing the upgrade job |
@Rahul-D78 please link the issue this fixes in the PR description next to "Fixes #" |
flake /retest |
HI @CecileRobertMichon I have added to issue number is it going to work now |
/retest |
/retest-required |
the upgrade jobs are still failing, need to investigate what's going on |
test/e2e/config/azure-dev.yaml
Outdated
@@ -103,7 +103,7 @@ variables: | |||
ETCD_VERSION_UPGRADE_TO: "3.4.3-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rahul-D78 can you please update etcd and coredns versions to:
ETCD_VERSION_UPGRADE_TO: "3.4.13-0"
COREDNS_VERSION_UPGRADE_TO: "1.8.4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sure
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-capi-e2e |
/test pull-cluster-api-provider-azure-capi-e2e |
I have made changes hope It passes all test cases ✔ |
/retest just checking if we got unlucky... |
@Rahul-D78: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I was able to repro locally. New upgraded nodes are not becoming ready, investigating.
/hold |
yes thanks for investing . |
/close After investigation (#1568) and per kubernetes-sigs/cluster-api#4896, the failing tests are to be deprecated. Closing this PR in favor of #1566 which will remove these tests. |
@CecileRobertMichon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should change the KUBERNETES_VERSION_UPGRADE_FROM variable default
in https://github.com/nader-ziada/cluster-api-provider-azure/blob/08f456963fb47f801e75eae730837e3cffe57bfc/test/e2e/config/azure-dev.yaml to v1.20.9 which is the latest 1.20 patch.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #1555 , ...)
format, will close the issue(s) when PR gets merged):Fixes #1555
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: