Use dl.k8s.io instead of hardcoded GCS URIs

[CecileRobertMichon]

kubernetes-sigs/cluster-api#4958

/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

kubernetes-sigs/cluster-api#4958

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sayantani11]

Hey is the issue open? I would like to contribute if I could get some insights and some help

[CecileRobertMichon]

Hi @sayantani11, yes it is. The ask is to replace all hardcoded usages of gs:// (https://github.com/kubernetes-sigs/cluster-api-provider-azure/search?q=gs%3A%2F%2F) with dl.k8s.io, just like kubernetes-sigs/cluster-api#4958 did for the Cluster API project.

Here is the motivation:

The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .)
Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us
as a project, since we can transparently change where that redirects to
without having to change code everywhere
These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release -> gs://k8s-release migration equivalent of the
CI migration we're going through right now
(kubernetes/k8s.io#2318)

Some of our yaml templates are generated so make sure you run make generate after making changes to make sure all templates are updated.

Feel free to reach out if you have any questions, here or on k8s slack (#cluster-api-azure)!

[CecileRobertMichon]

/assign sayantani11

[jayesh-srivastava]

Hey, @CecileRobertMichon I have made the necessary changes and made the PR. I have also signed the CLA, but its not working out. Can you please guide me?

[jayesh-srivastava]

I am a new contributor btw, and I really want to become a regular contributor.

[sayantani11]

@CecileRobertMichon Got it I am working on it

[sayantani11]

@jayesh-srivastava I guess before you make a PR the issue should be assigned to you. I requested to work on it first. So requesting to consider this.

[jayesh-srivastava]

@sayantani11 Oh okay. Didn't know about it. Sorry, all yours.

[CecileRobertMichon]

@jayesh-srivastava welcome! I look forward to your contributions. If you're looking for other good issues to work on, check out help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. (make sure no one is already assigned and comment /assign to mark yourself as working on the issue).

@sayantani11 thanks for opening the PR!

[jayesh-srivastava]

@CecileRobertMichon Thank you so much. Can new contributors join the kubernetes-sigs github org?

[CecileRobertMichon]

Here are the requirements to become a member: https://github.com/kubernetes/community/blob/master/community-membership.md#member

[jayesh-srivastava]

Thanks for sharing.

[CecileRobertMichon]

no problem! Also you should come hang out with us in the #cluster-api-azure channel on k8s slack if you're not already there

[jayesh-srivastava]

Thanks again for this. I joined the channel. Looking forward to learning with all you amazing guys.

[CecileRobertMichon]

Here's another easy first PR: #1555

[jayesh-srivastava]

Yeah was a bit late : ) Nevertheless will look out for good first issues. Thanks for helping.