-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update IAM policy template #3046
update IAM policy template #3046
Conversation
Co-authored-by: Joey Stout <[email protected]>
Co-authored-by: Joey Stout <[email protected]>
Codecov ReportBase: 54.07% // Head: 54.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## release-2.4 #3046 +/- ##
============================================
Coverage 54.07% 54.07%
============================================
Files 144 144
Lines 8301 8301
============================================
Hits 4489 4489
Misses 3484 3484
Partials 328 328 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
set ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20, since 2.4 branch uses go 1.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the same fix included upstream kubernetes-sigs/aws-load-balancer-controller#3046
Issue
Fixes: #2692
Description
This is a cherry-pick of PR #3045 to v2.4 branch.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯