Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update IAM policy template #3046

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Feb 10, 2023

Issue

Fixes: #2692

Description

This is a cherry-pick of PR #3045 to v2.4 branch.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2023
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2023
@kishorj kishorj changed the base branch from main to release-2.4 February 10, 2023 19:26
@kishorj kishorj added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 54.07% // Head: 54.07% // No change to project coverage 👍

Coverage data is based on head (6212633) compared to base (a92e689).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.4    #3046   +/-   ##
============================================
  Coverage        54.07%   54.07%           
============================================
  Files              144      144           
  Lines             8301     8301           
============================================
  Hits              4489     4489           
  Misses            3484     3484           
  Partials           328      328           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

set ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20, since 2.4 branch uses go 1.19
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@kishorj kishorj removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8632213 into kubernetes-sigs:release-2.4 Feb 23, 2023
eduardoweiland added a commit to quantosobra/terraform-aws-eks-lb-controller that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to create target group with default policy
6 participants