Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IAM policy template #33

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

eduardoweiland
Copy link
Contributor

@eduardoweiland eduardoweiland commented Jul 28, 2023

This should be the same as #32 but using the same policy template from upstream fix: kubernetes-sigs/aws-load-balancer-controller#3046. It's a more restrict version of the policy in #32.

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

@anphlax anphlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is highly needed. I was about to open a similar one, but found that this is the correct solution to the issue that creating targetGroups is not possible, due to wrong IAM Conditional Policy Statements.

@anphlax
Copy link

anphlax commented Sep 14, 2023

Please consider merging it soon, this TF module is the most used according to the terraform registry stats.

Copy link
Contributor

@brunodasilvalenga brunodasilvalenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunodasilvalenga brunodasilvalenga merged commit 148620d into DNXLabs:master Sep 27, 2023
@brunodasilvalenga brunodasilvalenga mentioned this pull request Sep 27, 2023
5 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants