Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iam.tf #32

Closed
wants to merge 1 commit into from
Closed

Update iam.tf #32

wants to merge 1 commit into from

Conversation

arathysn
Copy link

Adding explicit access to add tags in the ELB 'Create*' API calls.

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Access to attach tags was implicitly granted with permission to 'Create*' APIs. Now as an additional layer of security to ELB ‘Create*' API calls, API callers must have explicit access to add tags in their Identity and Access Management (IAM) policy . This new addition will satisfy that

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding explicit access to add tags in the ELB 'Create*' API calls
Copy link

@vargha04 vargha04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required change to fix alb.

Copy link

@vargha04 vargha04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required change to fix alb.

@eduardoweiland eduardoweiland mentioned this pull request Jul 28, 2023
7 tasks
@romankuzmik
Copy link

Please merge this one.
This is not exactly a change in https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/v2.5.4/docs/install/iam_policy.json, but close enough to comply with recent AIM change and fix an issue.
W/o PR this TF module is broken and won't function anymore.

@brunodasilvalenga
Copy link
Contributor

The PR #33 has been merged and includes the necessary IAM policies related to it.

I will close the issue.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants