Update translation on tutorials/hello-minikube.md #45

gochist · 2018-09-27T16:01:14Z

fixes #43

ianychoi

Only one deployment is my request change and the others are questions or suggestions. Please see my comment.

ianychoi · 2018-09-29T04:43:25Z

content/ko/docs/tutorials/hello-minikube.md


  {{< note >}}
-  **참고:** macOS 10.13 버전으로 업데이트 후 Homebrew에서 `brew update` 를 실행 시 다음과 같은 오류가 발생할 경우:
+  **참고:** macOS 10.13 버전으로 업데이트 후 `brew update`를 실행 시 Homebrew에서 다음과 같은 오류가 발생할 경우에는,


"brew update를" - [text] 다음에 띄어쓰기를 적어 주는 게 렌더링에 문제가 없는 것으로 알고 있습니다. 괜찮은지요?

붙여써도 렌더링에 문제 없음을 확인했습니다.

ianychoi · 2018-09-29T04:44:09Z

content/ko/docs/tutorials/hello-minikube.md


 ```shell
 kubectl config use-context minikube
 ```

-`kubectl` 이 클러스터와 통신할 수 있도록 설정되어 있는지 확인:
+`kubectl`이 클러스터와 통신할 수 있도록 설정되어 있는지 확인한다.


"kubectl이" - (ditto)

위와 같습니다. :)

ianychoi · 2018-09-29T04:46:17Z

content/ko/docs/tutorials/hello-minikube.md


 ```shell
 kubectl cluster-info
 ```

-브라우저에서 쿠버네티스 대시보드 열기:
+브라우저에서 쿠버네티스 대시보드를 연다.


[Suggestion] "대시보드를 연다." - 원 문장에서 :를 사용하고 있는데, 마침표로 바꾸는 부분을 차후 회의때 다루어도 좋을 것 같습니다.

한국어의 문장부호 쌍점과 영어의 문장부호 콜론의 용법이 달라 대체로 옮기지 않는 것으로 알고 있습니다.

네 그래서 다음 회의때 안건으로 이야기하자고 제안을 하였습니다.

content/ko/docs/tutorials/hello-minikube.md

ianychoi · 2018-09-29T08:45:23Z

/lgtm

claudiajkang · 2018-10-01T01:13:44Z

/assign
/approve

k8s-ci-robot · 2018-10-01T01:13:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ClaudiaJKang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fixes #43

* Initial translation of documentation home (kubernetes-retired/kubernetes-docs-ko#9) * 번역할 원본 파일 추가 (kubernetes-retired/kubernetes-docs-ko#11) * Translate tutorials/kubernetes-basics/create-cluster (kubernetes-retired/kubernetes-docs-ko#15) * Translate tutorials/kubernetes-basics/deploy-app in Korean (kubernetes-retired/kubernetes-docs-ko#16) * Translate tutorials/kubernetes-basics/expose in Korean (kubernetes-retired/kubernetes-docs-ko#26) * Translate tutorials/kubernetes-basics/scale in Korean (kubernetes-retired/kubernetes-docs-ko#24) * Fix typo from 세트 to 셋 according to 외래어 표기법 3.1.1 (kubernetes-retired/kubernetes-docs-ko#31) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#33) * Translated the welcome page in Korean (kubernetes-retired/kubernetes-docs-ko#32) * Translate tutorials/kubernetes-basics/update in Korean (kubernetes-retired/kubernetes-docs-ko#35) * Translate concepts/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#30) * Translate tutorials/kubernetes-basics/index.html in Korean (kubernetes-retired/kubernetes-docs-ko#29) * Translate /tutorials/hello-minikube.md in Korean (kubernetes-retired/kubernetes-docs-ko#18) * Translate tutorials/kubernetes-basics/explore in Korean (kubernetes-retired/kubernetes-docs-ko#36) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#42) * up-to-date on _index.html (kubernetes-retired/kubernetes-docs-ko#41) * Translate tutorials/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#44) * Update translation on tutorials/hello-minikube.md (kubernetes-retired/kubernetes-docs-ko#45) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#51) * Update tutorials for consistency (kubernetes-retired/kubernetes-docs-ko#48) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#53) Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Lawlait <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>

Korean translation of Home, Setup, Tutorials-Kubernetes Basics, Hello Minikube has been added. * Initial translation of documentation home (kubernetes-retired/kubernetes-docs-ko#9) * 번역할 원본 파일 추가 (kubernetes-retired/kubernetes-docs-ko#11) * Translate tutorials/kubernetes-basics/create-cluster (kubernetes-retired/kubernetes-docs-ko#15) * Translate tutorials/kubernetes-basics/deploy-app in Korean (kubernetes-retired/kubernetes-docs-ko#16) * Translate tutorials/kubernetes-basics/expose in Korean (kubernetes-retired/kubernetes-docs-ko#26) * Translate tutorials/kubernetes-basics/scale in Korean (kubernetes-retired/kubernetes-docs-ko#24) * Fix typo from 세트 to 셋 according to 외래어 표기법 3.1.1 (kubernetes-retired/kubernetes-docs-ko#31) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#33) * Translated the welcome page in Korean (kubernetes-retired/kubernetes-docs-ko#32) * Translate tutorials/kubernetes-basics/update in Korean (kubernetes-retired/kubernetes-docs-ko#35) * Translate concepts/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#30) * Translate tutorials/kubernetes-basics/index.html in Korean (kubernetes-retired/kubernetes-docs-ko#29) * Translate /tutorials/hello-minikube.md in Korean (kubernetes-retired/kubernetes-docs-ko#18) * Translate tutorials/kubernetes-basics/explore in Korean (kubernetes-retired/kubernetes-docs-ko#36) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#42) * up-to-date on _index.html (kubernetes-retired/kubernetes-docs-ko#41) * Translate tutorials/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#44) * Update translation on tutorials/hello-minikube.md (kubernetes-retired/kubernetes-docs-ko#45) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#51) * Update tutorials for consistency (kubernetes-retired/kubernetes-docs-ko#48) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#53) Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Lawlait <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>

Korean translation of Home, Setup, Tutorials-Kubernetes Basics, and Hello Minikube has been added. * Initial translation of documentation home (kubernetes-retired/kubernetes-docs-ko#9) * 번역할 원본 파일 추가 (kubernetes-retired/kubernetes-docs-ko#11) * Translate tutorials/kubernetes-basics/create-cluster (kubernetes-retired/kubernetes-docs-ko#15) * Translate tutorials/kubernetes-basics/deploy-app in Korean (kubernetes-retired/kubernetes-docs-ko#16) * Translate tutorials/kubernetes-basics/expose in Korean (kubernetes-retired/kubernetes-docs-ko#26) * Translate tutorials/kubernetes-basics/scale in Korean (kubernetes-retired/kubernetes-docs-ko#24) * Fix typo from 세트 to 셋 according to 외래어 표기법 3.1.1 (kubernetes-retired/kubernetes-docs-ko#31) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#33) * Translated the welcome page in Korean (kubernetes-retired/kubernetes-docs-ko#32) * Translate tutorials/kubernetes-basics/update in Korean (kubernetes-retired/kubernetes-docs-ko#35) * Translate concepts/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#30) * Translate tutorials/kubernetes-basics/index.html in Korean (kubernetes-retired/kubernetes-docs-ko#29) * Translate /tutorials/hello-minikube.md in Korean (kubernetes-retired/kubernetes-docs-ko#18) * Translate tutorials/kubernetes-basics/explore in Korean (kubernetes-retired/kubernetes-docs-ko#36) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#42) * up-to-date on _index.html (kubernetes-retired/kubernetes-docs-ko#41) * Translate tutorials/_index.md in Korean (kubernetes-retired/kubernetes-docs-ko#44) * Update translation on tutorials/hello-minikube.md (kubernetes-retired/kubernetes-docs-ko#45) * Setup page's header and subheader translate into Korean. (kubernetes-retired/kubernetes-docs-ko#51) * Update tutorials for consistency (kubernetes-retired/kubernetes-docs-ko#48) * up-to-date on content/ko (kubernetes-retired/kubernetes-docs-ko#53) Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Lawlait <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2018

k8s-ci-robot requested review from claudiajkang and ianychoi September 27, 2018 16:01

Update translation on tutorials/hello-minikube.md

0d373e8

fixes kubernetes-retired#43

gochist force-pushed the issue-43-tutorials-hello-minikube branch from dd27d9f to 0d373e8 Compare September 27, 2018 16:17

ianychoi suggested changes Sep 29, 2018

View reviewed changes

k8s-ci-robot assigned ianychoi Sep 29, 2018

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2018

ianychoi approved these changes Sep 29, 2018

View reviewed changes

k8s-ci-robot assigned claudiajkang Oct 1, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2018

k8s-ci-robot merged commit 86e665f into kubernetes-retired:dev-1.12-ko.2 Oct 1, 2018

gochist deleted the issue-43-tutorials-hello-minikube branch October 1, 2018 05:03

gochist added a commit that referenced this pull request Oct 2, 2018

Update translation on tutorials/hello-minikube.md (#45)

bf0137e

fixes #43

claudiajkang mentioned this pull request Oct 3, 2018

Added translation of documentation to Korean. k8s-kr/website#4

Merged

claudiajkang mentioned this pull request Oct 3, 2018

Add: Korean translation initialized kubernetes/website#10471

Merged

4 tasks

cblecker unassigned ianychoi and claudiajkang Oct 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update translation on tutorials/hello-minikube.md #45

Update translation on tutorials/hello-minikube.md #45

gochist commented Sep 27, 2018

ianychoi left a comment

ianychoi Sep 29, 2018

gochist Sep 29, 2018

ianychoi Sep 29, 2018

gochist Sep 29, 2018

ianychoi Sep 29, 2018

gochist Sep 29, 2018

ianychoi Sep 29, 2018

ianychoi commented Sep 29, 2018

claudiajkang commented Oct 1, 2018

k8s-ci-robot commented Oct 1, 2018

Update translation on tutorials/hello-minikube.md #45

Update translation on tutorials/hello-minikube.md #45

Conversation

gochist commented Sep 27, 2018

ianychoi left a comment

Choose a reason for hiding this comment

ianychoi Sep 29, 2018

Choose a reason for hiding this comment

gochist Sep 29, 2018

Choose a reason for hiding this comment

ianychoi Sep 29, 2018

Choose a reason for hiding this comment

gochist Sep 29, 2018

Choose a reason for hiding this comment

ianychoi Sep 29, 2018

Choose a reason for hiding this comment

gochist Sep 29, 2018

Choose a reason for hiding this comment

ianychoi Sep 29, 2018

Choose a reason for hiding this comment

ianychoi commented Sep 29, 2018

claudiajkang commented Oct 1, 2018

k8s-ci-robot commented Oct 1, 2018