Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release tools to fix broken image build pipeline #977

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 16, 2023

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Update release tools to fix broken image build pipeline

related to fix: kubernetes-csi/csi-release-tools#245

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Update release tools to fix broken image build pipeline
Change go version to 1.21.5
related to fix: kubernetes-csi/csi-release-tools#245

Squashed 'release-tools/' changes from f8c8cc4c..b54c1ba4
b54c1ba4 Merge pull request https://github.com/kubernetes-csi/external-snapshotter/issues/246 from xing-yang/go_1.21
5436c81e Change go version to 1.21.5
267b40e9 Merge pull request https://github.com/kubernetes-csi/external-snapshotter/pull/244 from carlory/sig-storage
b42e5a2d nominate self (carlory) as kubernetes-csi reviewer
a17f536f Merge pull request https://github.com/kubernetes-csi/external-snapshotter/pull/210 from sunnylovestiramisu/sidecar
011033de Use set -x instead of die
5deaf667 Add wrapper script for sidecar release

git-subtree-dir: release-tools
git-subtree-split: b54c1ba49469d4d5d1b5d75285e8868ffe3d328f

Does this PR introduce a user-facing change?:

none

Change go version to 1.21.5

b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21
5436c81 Change go version to 1.21.5
267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage
b42e5a2 nominate self (carlory) as kubernetes-csi reviewer
a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar
011033d Use set -x instead of die
5deaf66 Add wrapper script for sidecar release

git-subtree-dir: release-tools
git-subtree-split: b54c1ba
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2023
@xing-yang
Copy link
Collaborator

Can you add this commit message to the Special Notes section?
73708b3

@andyzhangx
Copy link
Member Author

Can you add this commit message to the Special Notes section? 73708b3

@xing-yang updated.

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@xing-yang
Copy link
Collaborator

@andyzhangx We typically copy the entire commit message. I've copied that over to the PR description area.

@k8s-ci-robot k8s-ci-robot merged commit 77c9868 into kubernetes-csi:master Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all csi repo image build pipelines are broken now due to golang binary download failure
3 participants