sidecar controller update, fix potential snapshot leaking #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @xing-yang |
|
cc @jingxu97 |
xing-yang
reviewed
Dec 16, 2019
xing-yang
reviewed
Dec 17, 2019
|
Have you tested this? Is there a visible delay in content deletion? |
It's kinda of hard to reproduce the leak issue. deletion via CSI happens really quick in real drivers like PD. I have, though, added unit testing to mimic driver error, and saw the finalizer is still there not removed. |
resolve comments
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang, yuxiangqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andyzhangx
added a commit
to andyzhangx/external-snapshotter
that referenced
this pull request
Dec 16, 2023
b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release git-subtree-dir: release-tools git-subtree-split: b54c1ba
andyzhangx
pushed a commit
to andyzhangx/external-snapshotter
that referenced
this pull request
Jun 5, 2024
Add wrapper script for sidecar release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind bug
What this PR does / why we need it:
clean up sidecar logic, fix potential snapshot leaking issue, added more test cases
Which issue(s) this PR fixes:
Fixes #209
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE