Add changelog for 2.0.1 release #244
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
| ## Breaking Changes | ||
|
|
||
| - Cherry pick PR #240: Fix go module requirements for semantic versioning. Update package path to v2. Vendoring with dep depends on https://github.com/golang/dep/pull/1963 or the workaround described in v2/README.md. ([#243](https://github.com/kubernetes-csi/external-snapshotter/pull/243), [@alex1989hu](https://github.com/alex1989hu)) |
There was a problem hiding this comment.
@jsafrane can you check if attacher also has similar issue?
There was a problem hiding this comment.
Maybe. I admit I still don't fully understand the issue even after reading #239
There was a problem hiding this comment.
If someone needs to do a "go get -v github.com/kubernetes-csi/[email protected]", that will probably fail with the similar error because there's no v2 in the package path.
There was a problem hiding this comment.
If you try to import a go module that's tagged with >= 2.0, the packages need to be in v2 directory. But some workarounds need to be done to still make it work with dep
There was a problem hiding this comment.
ack, filled kubernetes-csi/external-attacher#208
There was a problem hiding this comment.
After cutting the v2.0.1 release, I'm still getting the same errors. Need to figure out what else needs to be fixed.
There was a problem hiding this comment.
Kindly ask you to see my comments:
There was a problem hiding this comment.
Thanks @alex1989hu. I'll give it a try.
There was a problem hiding this comment.
Verified "go get -u github.com/kubernetes-csi/external-snapshotter/[email protected]" works for me now.
Also tested the manual steps to generate code and that works too.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release git-subtree-dir: release-tools git-subtree-split: b54c1ba
nominate self (carlory) as kubernetes-csi reviewer
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds changelog for 2.0.1 release.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: