Add istio sidecar inject false to deployments in kubeflow ns

[Bobgy]

Which issue is resolved by this Pull Request:
Part of kubeflow/pipelines#1223
Unblocks kubeflow/kfctl#131
Description of your changes:
Disabled istio sidecar injection for deployments in kubeflow namespace except for metadata related manifests. There was a problem with auto generated test cases for metadata, discussed in #716 separately.

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate-changed-only
  3. make test

/assign @jlewi

---

This change is 

[Bobgy]

@jlewi Can I get approval on this one? I will address issues in #716 separately.

[krishnadurai]

@Bobgy since this is for 'kubeflow' namespace, I suggest we avoid annotating 'cert-manager' with the istio-injection label? It is deployed to 'cert-manager' namespace.

[Bobgy]

Thanks for pointing that out. I will fix that.

EDIT: already fixed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jlewi
You can assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Bobgy]

/retest

[Bobgy]

I tried looking at test error message and found this in link

util.py                     72 INFO     failed to apply:  (kubeflow.error): Code 500 with message: coordinator Apply failed for gcp:  (kubeflow.error): Code 400 with message: gcp apply c
ould not update deployment manager Error Set New IamPolicy error: googleapi: Error 400: The number of members in the policy (1,505) is larger than the maximum allowed size 1,500., badReq
uest

Looks like the test project is reaching quota limit. Can someone help me clean them up?

[jlewi]

@Bobgy Can you please open a bug in kubeflow/testing ? And then ping in #buildcop in kubeflow.slack.com?

[jlewi]

Looks like we have kubeflow/testing#543

[jlewi]

/test all

[Bobgy]

/retest

[Bobgy]

/retest

[jlewi]

@Bobgy The RC branch for Kubeflow 1.0 has been cut so if you want this to make the cut I would suggest focusing on getting the tests passed and then cherry-picking it into the release branch.

It looks like the test_katib is ready test failed and the test_kf_is_ready test failed

The latter error

E     kubeflow.testing.util.TimeoutError: Timeout waiting for deployment cloud-endpoints-controller in namespace kubeflow

Looks like it might be related to kubeflow/kubeflow#4693 which should be fixed on master.
So you might want to rebase and try again.

/test all

[Bobgy]

/test kubeflow-manifests-presubmit
Each test seems to fail on a different case, seems flaky.

[Bobgy]

/retest

[k8s-ci-robot]

@Bobgy: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-manifests-presubmit	4b1ca00	link	/test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jlewi]

Most recent failure was the pytorch job failed to run.

I don't see why adding an annotation to the statefulset would affect that. So I'll go ahead and merge manually.

[Bobgy]

Thanks, @jlewi!