Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istio sidecar inject false to deployments in kubeflow ns #712

Merged
merged 4 commits into from
Jan 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion admission-webhook/webhook/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: deployment
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: gcr.io/kubeflow-images-public/admission-webhook:v20190520-v0-139-gcee39dbc-dirty-0d8f4c
Expand All @@ -16,4 +19,4 @@ spec:
- name: webhook-cert
secret:
secretName: webhook-certs
serviceAccountName: service-account
serviceAccountName: service-account
4 changes: 3 additions & 1 deletion aws/aws-alb-ingress-controller/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
metadata:
labels:
app.kubernetes.io/name: alb-ingress-controller
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: alb-ingress-controller
Expand Down Expand Up @@ -48,4 +50,4 @@ spec:
# Repository location of the ALB Ingress Controller.
image: docker.io/amazon/aws-alb-ingress-controller:v1.1.2
imagePullPolicy: Always
serviceAccountName: alb-ingress-controller
serviceAccountName: alb-ingress-controller
2 changes: 2 additions & 0 deletions common/basic-auth/base/gatekeeper-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ spec:
metadata:
labels:
app: basic-auth
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: app
Expand Down
2 changes: 2 additions & 0 deletions common/basic-auth/base/kflogin-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ spec:
metadata:
labels:
app: basic-auth-login
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: app
Expand Down
2 changes: 2 additions & 0 deletions common/centraldashboard/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ spec:
metadata:
labels:
app: centraldashboard
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: gcr.io/kubeflow-images-public/centraldashboard
Expand Down
2 changes: 2 additions & 0 deletions common/spartakus/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ spec:
metadata:
labels:
app: spartakus-volunteer
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- args:
Expand Down
2 changes: 2 additions & 0 deletions gcp/cloud-endpoints/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ spec:
metadata:
labels:
app: cloud-endpoints-controller
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: gcr.io/cloud-solutions-group/cloud-endpoints-controller:0.2.1
Expand Down
3 changes: 3 additions & 0 deletions jupyter/jupyter-web-app/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ metadata:
spec:
replicas: 1
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- env:
Expand Down
3 changes: 3 additions & 0 deletions jupyter/notebook-controller/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: deployment
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: manager
Expand Down
2 changes: 2 additions & 0 deletions katib/katib-controller/base/katib-controller-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ spec:
metadata:
labels:
app: katib-controller
annotations:
sidecar.istio.io/inject: "false"
spec:
serviceAccountName: katib-controller
containers:
Expand Down
2 changes: 2 additions & 0 deletions katib/katib-controller/base/katib-db-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
labels:
app: katib
component: db
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: katib-db
Expand Down
2 changes: 2 additions & 0 deletions katib/katib-controller/base/katib-manager-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
labels:
app: katib
component: manager
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: katib-manager
Expand Down
2 changes: 2 additions & 0 deletions katib/katib-controller/base/katib-ui-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
labels:
app: katib
component: ui
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: katib-ui
Expand Down
2 changes: 2 additions & 0 deletions kubebench/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ spec:
metadata:
labels:
app: kubebench-operator
annotations:
sidecar.istio.io/inject: "false"
spec:
volumes:
- name: kubebench-config
Expand Down
2 changes: 2 additions & 0 deletions modeldb/base/artifact-store-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
labels:
app: modeldb
tier: artifact-store
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- env:
Expand Down
2 changes: 2 additions & 0 deletions modeldb/base/backend-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
labels:
app: modeldb
tier: backend
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- env:
Expand Down
2 changes: 2 additions & 0 deletions modeldb/base/mysql-backend-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
labels:
app: modeldb
tier: mysql
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- args:
Expand Down
2 changes: 2 additions & 0 deletions modeldb/base/proxy-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
labels:
app: modeldb
tier: backend-proxy
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- args:
Expand Down
2 changes: 2 additions & 0 deletions modeldb/base/webapp-deplyment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
labels:
app: modeldb
tier: webapp
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: vertaaiofficial/modeldb-frontend:kubeflow
Expand Down
2 changes: 2 additions & 0 deletions mpi-job/mpi-operator/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ spec:
metadata:
labels:
app: mpi-operator
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- args:
Expand Down
2 changes: 2 additions & 0 deletions mxnet-job/mxnet-operator/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ spec:
metadata:
labels:
name: mxnet-operator
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- command:
Expand Down
9 changes: 6 additions & 3 deletions pipeline/api-service/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: ml-pipeline
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: ml-pipeline-api-server
Expand All @@ -15,17 +18,17 @@ spec:
image: gcr.io/ml-pipeline/api-server
imagePullPolicy: IfNotPresent
command:
- apiserver
- apiserver
- --config=/etc/ml-pipeline-config
- --sampleconfig=/config/sample_config.json
- --sampleconfig=/config/sample_config.json
- -logtostderr=true
ports:
- containerPort: 8888
- containerPort: 8887
volumeMounts:
- name: config-volume
mountPath: /etc/ml-pipeline-config
serviceAccountName: ml-pipeline
serviceAccountName: ml-pipeline
volumes:
- name: config-volume
configMap:
Expand Down
3 changes: 3 additions & 0 deletions pipeline/minio/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ spec:
strategy:
type: Recreate
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: minio
Expand Down
3 changes: 3 additions & 0 deletions pipeline/mysql/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ spec:
strategy:
type: Recreate
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: mysql
Expand Down
3 changes: 3 additions & 0 deletions pipeline/persistent-agent/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: persistenceagent
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: ml-pipeline-persistenceagent
Expand Down
2 changes: 2 additions & 0 deletions pipeline/pipeline-visualization-service/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ spec:
metadata:
labels:
app: ml-pipeline-visualizationserver
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: gcr.io/ml-pipeline/visualization-server
Expand Down
2 changes: 2 additions & 0 deletions pipeline/pipelines-ui/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ spec:
metadata:
labels:
app: ml-pipeline-ui
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: ml-pipeline-ui
Expand Down
3 changes: 3 additions & 0 deletions pipeline/pipelines-ui/overlays/gcp/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: ml-pipeline-ui
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
volumes:
- name: gcp-sa-token
Expand Down
3 changes: 3 additions & 0 deletions pipeline/pipelines-viewer/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: controller-deployment
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- env:
Expand Down
3 changes: 3 additions & 0 deletions pipeline/scheduledworkflow/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ metadata:
name: ml-pipeline-scheduledworkflow
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: ml-pipeline-scheduledworkflow
Expand Down
3 changes: 3 additions & 0 deletions profiles/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ metadata:
spec:
replicas: 1
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- command:
Expand Down
2 changes: 2 additions & 0 deletions pytorch-job/pytorch-operator/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ spec:
metadata:
labels:
name: pytorch-operator
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- command:
Expand Down
1 change: 1 addition & 0 deletions spark/spark-operator/base/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ spec:
prometheus.io/path: /metrics
prometheus.io/port: "10254"
prometheus.io/scrape: "true"
sidecar.istio.io/inject: "false"
initializers:
pending: []
labels:
Expand Down
2 changes: 2 additions & 0 deletions tektoncd/tektoncd-dashboard/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ spec:
template:
metadata:
name: tekton-dashboard
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- name: tekton-dashboard
Expand Down
2 changes: 2 additions & 0 deletions tektoncd/tektoncd-install/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ spec:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
sidecar.istio.io/inject: "false"
labels:
app: tekton-pipelines-controller
# app.kubernetes.io/component: controller
Expand Down Expand Up @@ -83,6 +84,7 @@ spec:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
sidecar.istio.io/inject: "false"
labels:
app: tekton-pipelines-webhook
# app.kubernetes.io/component: webhook-controller
Expand Down
2 changes: 2 additions & 0 deletions tensorboard/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ spec:
metadata:
labels:
app: tensorboard
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- args:
Expand Down
5 changes: 4 additions & 1 deletion tests/admission-webhook-webhook-base_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ metadata:
name: deployment
spec:
template:
metadata:
annotations:
sidecar.istio.io/inject: "false"
spec:
containers:
- image: gcr.io/kubeflow-images-public/admission-webhook:v20190520-v0-139-gcee39dbc-dirty-0d8f4c
Expand All @@ -113,7 +116,7 @@ spec:
- name: webhook-cert
secret:
secretName: webhook-certs
serviceAccountName: service-account
serviceAccountName: service-account
`)
th.writeF("/manifests/admission-webhook/webhook/base/mutating-webhook-configuration.yaml", `
apiVersion: admissionregistration.k8s.io/v1beta1
Expand Down
Loading