Add istio sidecar inject false to deployments in kubeflow ns (kubeflo…

…w#712) * Add istio sidecar inject false to deployments * Revert cert-manager changes * Revert unneeded changes
vpavlin · Feb 18, 2020 · 2eb94cb · 2eb94cb
1 parent d59fead
commit 2eb94cb
Show file tree

Hide file tree

Showing 108 changed files with 12,116 additions and 16 deletions.
diff --git a/admission-webhook/webhook/base/deployment.yaml b/admission-webhook/webhook/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: deployment
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - image: gcr.io/kubeflow-images-public/admission-webhook:v20190520-v0-139-gcee39dbc-dirty-0d8f4c
@@ -16,4 +19,4 @@ spec:
       - name: webhook-cert
         secret:
           secretName: webhook-certs
-      serviceAccountName: service-account    
+      serviceAccountName: service-account
diff --git a/aws/aws-alb-ingress-controller/base/deployment.yaml b/aws/aws-alb-ingress-controller/base/deployment.yaml
@@ -17,6 +17,8 @@ spec:
     metadata:
       labels:
         app.kubernetes.io/name: alb-ingress-controller
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
         - name: alb-ingress-controller
@@ -48,4 +50,4 @@ spec:
           # Repository location of the ALB Ingress Controller.
           image: docker.io/amazon/aws-alb-ingress-controller:v1.1.2
           imagePullPolicy: Always
-      serviceAccountName: alb-ingress-controller
+      serviceAccountName: alb-ingress-controller
diff --git a/common/basic-auth/base/gatekeeper-deployment.yaml b/common/basic-auth/base/gatekeeper-deployment.yaml
@@ -13,6 +13,8 @@ spec:
     metadata:
       labels:
         app: basic-auth
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: app

diff --git a/common/basic-auth/base/kflogin-deployment.yaml b/common/basic-auth/base/kflogin-deployment.yaml
@@ -13,6 +13,8 @@ spec:
     metadata:
       labels:
         app: basic-auth-login
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: app

diff --git a/common/centraldashboard/base/deployment.yaml b/common/centraldashboard/base/deployment.yaml
@@ -13,6 +13,8 @@ spec:
     metadata:
       labels:
         app: centraldashboard
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - image: gcr.io/kubeflow-images-public/centraldashboard

diff --git a/common/spartakus/base/deployment.yaml b/common/spartakus/base/deployment.yaml
@@ -10,6 +10,8 @@ spec:
     metadata:
       labels:
         app: spartakus-volunteer
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - args:

diff --git a/gcp/cloud-endpoints/base/deployment.yaml b/gcp/cloud-endpoints/base/deployment.yaml
@@ -8,6 +8,8 @@ spec:
     metadata:
       labels:
         app: cloud-endpoints-controller
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - image: gcr.io/cloud-solutions-group/cloud-endpoints-controller:0.2.1

diff --git a/jupyter/jupyter-web-app/base/deployment.yaml b/jupyter/jupyter-web-app/base/deployment.yaml
@@ -5,6 +5,9 @@ metadata:
 spec:
   replicas: 1
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - env:

diff --git a/jupyter/notebook-controller/base/deployment.yaml b/jupyter/notebook-controller/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: deployment
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: manager

diff --git a/katib/katib-controller/base/katib-controller-deployment.yaml b/katib/katib-controller/base/katib-controller-deployment.yaml
@@ -13,6 +13,8 @@ spec:
     metadata:
       labels:
         app: katib-controller
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       serviceAccountName: katib-controller
       containers:

diff --git a/katib/katib-controller/base/katib-db-deployment.yaml b/katib/katib-controller/base/katib-db-deployment.yaml
@@ -17,6 +17,8 @@ spec:
       labels:
         app: katib
         component: db
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: katib-db

diff --git a/katib/katib-controller/base/katib-manager-deployment.yaml b/katib/katib-controller/base/katib-manager-deployment.yaml
@@ -17,6 +17,8 @@ spec:
       labels:
         app: katib
         component: manager
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: katib-manager

diff --git a/katib/katib-controller/base/katib-ui-deployment.yaml b/katib/katib-controller/base/katib-ui-deployment.yaml
@@ -17,6 +17,8 @@ spec:
       labels:
         app: katib
         component: ui
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: katib-ui

diff --git a/kubebench/base/deployment.yaml b/kubebench/base/deployment.yaml
@@ -10,6 +10,8 @@ spec:
     metadata:
       labels:
         app: kubebench-operator
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       volumes:
       - name: kubebench-config

diff --git a/modeldb/base/artifact-store-deployment.yaml b/modeldb/base/artifact-store-deployment.yaml
@@ -17,6 +17,8 @@ spec:
       labels:
         app: modeldb
         tier: artifact-store
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - env:

diff --git a/modeldb/base/backend-deployment.yaml b/modeldb/base/backend-deployment.yaml
@@ -16,6 +16,8 @@ spec:
       labels:
         app: modeldb
         tier: backend
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - env:

diff --git a/modeldb/base/mysql-backend-deployment.yaml b/modeldb/base/mysql-backend-deployment.yaml
@@ -16,6 +16,8 @@ spec:
       labels:
         app: modeldb
         tier: mysql
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - args:

diff --git a/modeldb/base/proxy-deployment.yaml b/modeldb/base/proxy-deployment.yaml
@@ -16,6 +16,8 @@ spec:
       labels:
         app: modeldb
         tier: backend-proxy
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - args:

diff --git a/modeldb/base/webapp-deplyment.yaml b/modeldb/base/webapp-deplyment.yaml
@@ -16,6 +16,8 @@ spec:
       labels:
         app: modeldb
         tier: webapp
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - image: vertaaiofficial/modeldb-frontend:kubeflow

diff --git a/mpi-job/mpi-operator/base/deployment.yaml b/mpi-job/mpi-operator/base/deployment.yaml
@@ -11,6 +11,8 @@ spec:
     metadata:
       labels:
         app: mpi-operator
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - args:

diff --git a/mxnet-job/mxnet-operator/base/deployment.yaml b/mxnet-job/mxnet-operator/base/deployment.yaml
@@ -8,6 +8,8 @@ spec:
     metadata:
       labels:
         name: mxnet-operator
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - command:

diff --git a/pipeline/api-service/base/deployment.yaml b/pipeline/api-service/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: ml-pipeline
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: ml-pipeline-api-server
@@ -15,17 +18,17 @@ spec:
         image: gcr.io/ml-pipeline/api-server
         imagePullPolicy: IfNotPresent
         command:
-          - apiserver 
+          - apiserver
           - --config=/etc/ml-pipeline-config
-          - --sampleconfig=/config/sample_config.json 
+          - --sampleconfig=/config/sample_config.json
           - -logtostderr=true
         ports:
         - containerPort: 8888
         - containerPort: 8887
         volumeMounts:
         - name: config-volume
           mountPath: /etc/ml-pipeline-config
-      serviceAccountName: ml-pipeline      
+      serviceAccountName: ml-pipeline
       volumes:
         - name: config-volume
           configMap:

diff --git a/pipeline/minio/base/deployment.yaml b/pipeline/minio/base/deployment.yaml
@@ -6,6 +6,9 @@ spec:
   strategy:
     type: Recreate
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: minio

diff --git a/pipeline/mysql/base/deployment.yaml b/pipeline/mysql/base/deployment.yaml
@@ -6,6 +6,9 @@ spec:
   strategy:
     type: Recreate
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: mysql

diff --git a/pipeline/persistent-agent/base/deployment.yaml b/pipeline/persistent-agent/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: persistenceagent
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: ml-pipeline-persistenceagent

diff --git a/pipeline/pipeline-visualization-service/base/deployment.yaml b/pipeline/pipeline-visualization-service/base/deployment.yaml
@@ -12,6 +12,8 @@ spec:
     metadata:
       labels:
         app: ml-pipeline-visualizationserver
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - image: gcr.io/ml-pipeline/visualization-server

diff --git a/pipeline/pipelines-ui/base/deployment.yaml b/pipeline/pipelines-ui/base/deployment.yaml
@@ -12,6 +12,8 @@ spec:
     metadata:
       labels:
         app: ml-pipeline-ui
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: ml-pipeline-ui

diff --git a/pipeline/pipelines-ui/overlays/gcp/deployment.yaml b/pipeline/pipelines-ui/overlays/gcp/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: ml-pipeline-ui
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       volumes:
       - name: gcp-sa-token

diff --git a/pipeline/pipelines-viewer/base/deployment.yaml b/pipeline/pipelines-viewer/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: controller-deployment
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - env:

diff --git a/pipeline/scheduledworkflow/base/deployment.yaml b/pipeline/scheduledworkflow/base/deployment.yaml
@@ -4,6 +4,9 @@ metadata:
   name: ml-pipeline-scheduledworkflow
 spec:
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: ml-pipeline-scheduledworkflow

diff --git a/profiles/base/deployment.yaml b/profiles/base/deployment.yaml
@@ -5,6 +5,9 @@ metadata:
 spec:
   replicas: 1
   template:
+    metadata:
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - command:

diff --git a/pytorch-job/pytorch-operator/base/deployment.yaml b/pytorch-job/pytorch-operator/base/deployment.yaml
@@ -11,6 +11,8 @@ spec:
     metadata:
       labels:
         name: pytorch-operator
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - command:

diff --git a/spark/spark-operator/base/deploy.yaml b/spark/spark-operator/base/deploy.yaml
@@ -16,6 +16,7 @@ spec:
         prometheus.io/path: /metrics
         prometheus.io/port: "10254"
         prometheus.io/scrape: "true"
+        sidecar.istio.io/inject: "false"
       initializers:
         pending: []
       labels:

diff --git a/tektoncd/tektoncd-dashboard/base/deployment.yaml b/tektoncd/tektoncd-dashboard/base/deployment.yaml
@@ -7,6 +7,8 @@ spec:
   template:
     metadata:
       name: tekton-dashboard
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - name: tekton-dashboard

diff --git a/tektoncd/tektoncd-install/base/deployment.yaml b/tektoncd/tektoncd-install/base/deployment.yaml
@@ -15,6 +15,7 @@ spec:
     metadata:
       annotations:
         cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
+        sidecar.istio.io/inject: "false"
       labels:
         app: tekton-pipelines-controller
 #        app.kubernetes.io/component: controller
@@ -83,6 +84,7 @@ spec:
     metadata:
       annotations:
         cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
+        sidecar.istio.io/inject: "false"
       labels:
         app: tekton-pipelines-webhook
 #        app.kubernetes.io/component: webhook-controller

diff --git a/tensorboard/base/deployment.yaml b/tensorboard/base/deployment.yaml
@@ -10,6 +10,8 @@ spec:
     metadata:
       labels:
         app: tensorboard
+      annotations:
+        sidecar.istio.io/inject: "false"
     spec:
       containers:
       - args: