Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct log level docs #1153

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

mittal-ishaan
Copy link
Contributor

@mittal-ishaan mittal-ishaan commented Nov 10, 2024

Related PR

kubecost/cost-analyzer-helm-chart#3717

Proposed Changes

Update the docs for setting log level in helm values to use logLevel property instead of setting it in extra Env

Copy link
Member

@thomasvn thomasvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We should hold off on merging until the v2.5 release goes out.

@thomasvn thomasvn added the v2.5 label Nov 11, 2024
@mittal-ishaan mittal-ishaan merged commit 3da349a into main Dec 6, 2024
5 checks passed
@mittal-ishaan mittal-ishaan deleted the correct_log_level_docs_kubecostCostModel branch December 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants