correct settting log level in readme #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvn
reviewed
Nov 11, 2024
thomasvn
reviewed
Nov 11, 2024
|
Minor comments on wording. This looks good to me! When approved, I think we should hold on merging until v2.5 is officially released. |
thomasvn
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Looks good to me, thanks @mittal-ishaan ! Let's hold off on merging until v2.5 is officially released.
mittal-ishaan
force-pushed
the
correct_log_level_docs_kubecostCostModel
branch
from
1f5f9a6 to
67f97c9
Compare
Co-authored-by: Thomas Nguyen <[email protected]>
Co-authored-by: Thomas Nguyen <[email protected]>
mittal-ishaan
force-pushed
the
correct_log_level_docs_kubecostCostModel
branch
from
67f97c9 to
3b934e4
Compare
jessegoodier
pushed a commit
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Thomas Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Update the docs for setting log level in helm values to use logLevel property instead of setting it in extra Env
Does this PR rely on any other PRs?
#3717
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Updating the docs around setting log level for users to be able to set it correctly
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
NA
How was this PR tested?
Have you made an update to documentation? If so, please provide the corresponding PR.
Yes, kubecost/docs#1153