feat(tests): improve tests #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickleet
force-pushed
the
feat/improve-tests
branch
from
5d83a26 to
56ccc8b
Compare
This was referenced Sep 16, 2020
patrickleet
commented
Sep 16, 2020
| keycloak-controller-chart: | ||
| - 0.6.1 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| - name: Fetch history | ||
| run: git fetch --prune --unshallow | ||
| - name: mvn build | ||
| run: .github/mvn-build.sh |
There was a problem hiding this comment.
if maven fails there is no reason to start a kube cluster, so build maven first
patrickleet
force-pushed
the
feat/improve-tests
branch
4 times, most recently
from
ee1d69c to
b286530
Compare
feat(micronaut): upgrade to 1.3.7 and testing lib 1.2.3 feat(test): try to actually create keycloak connection in test feat(test): food-realm feat(test): keycloak username feat(test): connect realms to keycloak feat(test): client-example fix: more logs fix: try testing latest only fix: debug fix: create keycloak-auth secret and configure keycloak via values file fix: values file syntax fix: file path fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: debug keycloak fix: rm debug stuff fix: revert pom version changes fix: keycloak crd expects a secret with pw fix: rm debug log fix: revert kind change fix: proxy forwarding fix: proxy forwarding fix: use secret to auth with same creds in keycloak and keycloak controller admin client connection fix: revert keycloak chart change fix: https://stackoverflow.com/questions/57643079/kubernetes-watchconnectionmanager-exec-failure-http-403 fix: upgrade to latest k8s-client before API changes fix: upgrade to latest k8s-client before API changes
patrickleet
force-pushed
the
feat/improve-tests
branch
from
c5b9a57 to
310d6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the tests don't actually test anything, so I'm working on making tests that test things via examples that actually work.
The structure of the tests via the matrix was a good start so I built on that.
Keycloak does not try to keep backwards compatibility and we shouldn't either. If we do want to provide support for that it's going to need to be a bit more complex - i.e. pass in the keycloak library version and run multiple docker builds that result in multiple docker artifacts.