fix(kube-client): upgrade fabric8io/kubernetes-client to 4.11.1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it'd probably be good to set up renovate, that way updates like these would have PRs created automatically - the pipelines seem robust enough that it'd be a good addition |
patrickleet
force-pushed
the
feat/upgrade-kube-client
branch
2 times, most recently
from
40f359c to
6b34b7a
Compare
|
well, as you can see, that did not work all the examples I can find are still using withVersion, so idk what's up with that |
fix(kube-client): https://github.com/fabric8io/kubernetes-client/releases/tag/v4.11.0 CustomResourceDefinition class has moved fix(kube-client): https://github.com/fabric8io/kubernetes-client/releases/tag/v4.11.0 CustomResourceDefinition class has moved fix(kube-client): version is in package - withVersion function is gone fix(kube-client): version is in package - getVersion function is gone fix(crds): use crd v1 fix(crds): kiwigrid is still v1beta1 fix(crds): withApiVersion fix(crds): revert to withVersion fix(crds): revert to withVersion fix(crds): order? fix(crds): follow example from https://github.com/fabric8io/kubernetes-client/blob/master/doc/CHEATSHEET.md\#customresource-typeless-api in RealmResource fix(crds): metadata name fix(crds): try v1beta1 ??? fix(crds): more v1beta1s fix(crds): revert changes
patrickleet
force-pushed
the
feat/upgrade-kube-client
branch
from
8095317 to
be9d28a
Compare
|
got Also, I noticed the examples all rely on a realm 'food-realm' that isn't actually created? |
|
in working on this it became pretty clear that the tests need improvement - doing that in #37 will come back to these upgrades once we have better tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34 is a kubernetes client error, so maybe just updating to the latest kubernetes client version is all that's needed to fix it.