Fix field visilibity in AdminUI when omitted #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
commented
Jul 25, 2023
| ? f.ui?.listView?.fieldMode ?? f.ui?.listView?.defaultFieldMode | ||
| : 'hidden', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I have moved this behaviour from createAdminMeta.ts to logically group this near isEnabled - types-for-lists.ts is not an appropriate name
dcousens
commented
Jul 25, 2023
| @@ -62,6 +62,8 @@ function getSudoGraphQLSchema(config: KeystoneConfig) { | |||
| const lists = initialiseLists(transformedConfig); | |||
| const adminMeta = createAdminMeta(transformedConfig, lists); | |||
| return createGraphQLSchema(transformedConfig, lists, adminMeta, true); | |||
| // TODO: adminMeta not required | |||
| // return createGraphQLSchema(transformedConfig, lists, null, true); | |||
There was a problem hiding this comment.
I can't think of a reason why a sudo context would have an adminMeta, but this would be a breaking change if someone was querying that using getContext or similar
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5224880:
|
dcousens
changed the title
graphql.omit: true
dcousens
force-pushed
the
omit-test
branch
3 times, most recently
from
0c63b58 to
4493ff4
Compare
borisno2
approved these changes
Jul 27, 2023
|
Looks good, looks like a test is failing though |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8714, and switches to verbose snapshot testing of the possibility space in https://github.com/keystonejs/keystone/pull/8715/files#diff-c56d1cc3cff659fd4ab13d4370524a79120c964e3279953eeb0782fc79a48ca5, that way we can track visibility changes easily moving forward.