ui.hideCreate and ui.hideDelete don't work when graphql.omit.create and graphql.omit.delete are set

[tv42]

$ yarn create keystone-app
$ cd keystonejs-bug-hidecreate-hidedelete
$ npm run dev

Open browser. Create first user, navigate to /posts. Observe create button.

Edit schema.ts, add to lists.Post a section ui: { hideCreate: true },.
Observe browser page hide create button.

Add section graphql: {omit: {create: true}},.
Observe browser page start showing create button again.

Same is true for delete, with ui: { hideDelete: true}, and graphql: {omit: {delete: true}},.

Create/delete should stay hidden whenever ui.hideCreate/ui.hideDelete is true. graphql.omit.* should only be a fallback, and not affect the hiding when the ui.* settings are explicitly set.

Current dependencies from yarn create-app:

  "dependencies": {
    "@keystone-6/auth": "^7.0.0",
    "@keystone-6/core": "^5.0.0",
    "@keystone-6/fields-document": "^7.0.0",
    "typescript": "^4.9.5"
  }

Earlier related issue: #8714 (PR #8715).

[tv42]

This logic is hilariously wrong. It says do NOT hide the button if graphql API is disabled. Ternary expressions claim another victim.

      hideCreate: normalizeMaybeSessionFunction(
        list.graphql.isEnabled.create ? listConfig.ui?.hideCreate ?? false : false
      ),

Proposed fix:

      hideCreate: normalizeMaybeSessionFunction(
        listConfig.ui?.hideCreate ?? !list.graphql.isEnabled.create,
      ),

That is, use whatever developer said explicitly; if no explicit configuration, hide when GraphQL API is not enabled.

Same for delete.

[dcousens]

@tv42 nice. I'll make a pull request.

I don't blame the ternary expression though, I think our use of inverted boolean logic (hide*, omit) is a pattern that is repeatedly causing downstream [and upstream] errors.