Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field visible when graphql.omit: true #8714

Closed
pc-erin opened this issue Jul 24, 2023 · 4 comments · Fixed by #8715
Closed

Field visible when graphql.omit: true #8714

pc-erin opened this issue Jul 24, 2023 · 4 comments · Fixed by #8715
Assignees
Labels
🐛 bug Unresolved bug

Comments

@pc-erin
Copy link

pc-erin commented Jul 24, 2023

Steps to reproduce the problem

Create a text field.
Set ui.itemView.fieldMode to "hidden".
Set graphql.omit.update to true.

What you expected to happen

The field is not visible.

What actually happens

The field is still visible.

@dcousens

This comment was marked as outdated.

@dcousens dcousens added the 🐛 bug Unresolved bug label Jul 25, 2023
@dcousens
Copy link
Member

dcousens commented Jul 25, 2023

Sorry, ignore my previous comment, somehow this only happens if you set both exactly both fieldMode and the graphql.omit, resolving this now

        graphql: {
          omit: {
            update: true
          },
        },
        ui: {
          itemView: {
            fieldMode: 'hidden'
          }
        }

@dcousens dcousens changed the title Field is visible when it shouldn't be Field visible when graphql.omit: true Jul 25, 2023
@dcousens
Copy link
Member

Thanks for reporting this @pc-erin, fixed in #8715

@tv42
Copy link

tv42 commented Jul 16, 2024

It seems the fix is wrong. See #9216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unresolved bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants