Improve active icon states #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toggle like action Signed-off-by: Cvetanka <[email protected]>
… be represented only by the icon color Signed-off-by: Cvetanka <[email protected]>
Signed-off-by: Cvetanka <[email protected]>
Signed-off-by: Cvetanka <[email protected]>
Signed-off-by: Cvetanka <[email protected]>
cvetankanechevska
requested review from
tynandebold,
rashidakanchwala and
Huongg
Signed-off-by: Cvetanka <[email protected]>
…prove-active-icon-states Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
approved these changes
Jun 16, 2022
| @@ -42,6 +42,7 @@ export const ExperimentPrimaryToolbar = ({ | |||
| labelText={`${selectedRunData?.bookmark ? 'Unbookmark' : 'Bookmark'}`} | |||
| onClick={() => toggleBookmark()} | |||
| visible={!enableComparisonView} | |||
| active={selectedRunData?.bookmark} | |||
There was a problem hiding this comment.
Nit (coding style): I try to advise us to alphabetically sort component props, and also when destructuring and even CSS styles, where applicable. It makes readability easier when you know there's an order to things. There's a great VSCode extension that makes this easy, and would assume there's ways to do this in other IDEs as well.
There was a problem hiding this comment.
Thanks, I will update it.
Signed-off-by: Cvetanka <[email protected]>
…ro-viz into improve-active-icon-states Signed-off-by: Cvetanka <[email protected]>
comym
approved these changes
Jun 16, 2022
…ro-viz into improve-active-icon-states Signed-off-by: Cvetanka <[email protected]>
Signed-off-by: Cvetanka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #902
Development notes
Added active status for icons that represent a "toggle like action":
QA notes
Tested locally on dark and light theme.
Checklist
RELEASE.mdfile