Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.3.3 #1450

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Release 6.3.3 #1450

merged 2 commits into from
Jul 12, 2023

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Jul 12, 2023

Description

It's a patch release to fix Kedro-viz backward compatibility issue with Kedro and also fix compatibility with strawberry-graphql. Below are release notes :

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@rashidakanchwala rashidakanchwala requested review from Huongg and ravi-kumar-pilla and removed request for yetudada July 12, 2023 13:05
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and its working fine for me. Thanks @rashidakanchwala

kedro  0.18.11
kedro-datasets  1.4.0
kedro-viz  6.3.3

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashidakanchwala rashidakanchwala merged commit 93caf4a into main Jul 12, 2023
@rashidakanchwala rashidakanchwala deleted the release/6.3.3 branch July 12, 2023 14:16
@@ -1,6 +1,6 @@
{
"name": "@quantumblack/kedro-viz",
"version": "6.3.2",
"version": "6.3.3",
"lockfileVersion": 2,
"requires": true,
"packages": {
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the PR is merged. I was trying to build the package and saw the version under packages section is not updated to 6.3.3
@rashidakanchwala should we do that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tynandebold -- how do we do this best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants