Make Kedro-Viz compatible with previous Kedro with 'DataSet' #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojuanlu
reviewed
Jul 11, 2023
astrojuanlu
reviewed
Jul 11, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
deepyaman
changed the title
deepyaman
force-pushed
the
make-kedro-viz-compatible-with-old-kedro
branch
from
a3fc436 to
e9e9d73
Compare
|
@rashidakanchwala @astrojuanlu I think #1447 should work (there's one lint error, I honestly am not seeing why off the top of my head), but it would require releasing Kedro with the type hint changes in kedro-org/kedro#2788. So, until it's released, will ignore the errors. I'll make the changes on this branch now to ignore. |
deepyaman
force-pushed
the
make-kedro-viz-compatible-with-old-kedro
branch
2 times, most recently
from
8d63d11 to
0f21fe7
Compare
|
finally, thanks @deepyaman @astrojuanlu and @merelcht -- can we pls review this! |
deepyaman
approved these changes
Jul 12, 2023
deepyaman
reviewed
Jul 12, 2023
rashidakanchwala
added a commit
that referenced
this pull request
Jul 12, 2023
It's a patch release to fix Kedro-viz backward compatibility issue with Kedro and also fix compatibility with strawberry-graphql. Below are release notes : Bump strawberry-graphql to at least version 0.192 to support the new strawberry.union syntax. (Fix strawberry-graphql union error. #1441) Resolve the incompatibility between Kedro-Viz and Kedro versions prior to 0.18.11. (Make Kedro-Viz compatible with previous Kedro with 'DataSet' #1445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Kedro version 0.18.11, 'DataSet' was changed to 'Dataset' in several places. This change was also reflected in Kedro-viz to align with the latest Kedro version. However, this created compatibility issues for users who are using the latest Kedro-viz with a previous version of Kedro.
To address this problem and ensure Kedro-viz supports older versions of Kedro. In this PR, we handle the situation by attempting to import the newer 'Dataset' first. If an ImportError is raised, indicating that the newer version is not available, we catch the error and import the older 'DataSet' instead.
Development notes
QA notes
Checklist
RELEASE.mdfile