Fix strawberry-graphql union error. #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we introduce this with a recent version bump or is it another issue stemming from the |
rashidakanchwala
requested review from
tynandebold
and removed request for
tynandebold and
yetudada
|
@tynandebold - yeah we upgraded mypy 1.0 and so unpinned the strawberry-version which was previously pinned to only 0.180 and lower. Also updated to the latest recommended way of doing strawberry.union in the previous PR due to strawberry-graphql deprecation warnings. |
astrojuanlu
reviewed
Jul 11, 2023
1 task
tynandebold
approved these changes
Jul 11, 2023
rashidakanchwala
added a commit
that referenced
this pull request
Jul 12, 2023
It's a patch release to fix Kedro-viz backward compatibility issue with Kedro and also fix compatibility with strawberry-graphql. Below are release notes : Bump strawberry-graphql to at least version 0.192 to support the new strawberry.union syntax. (Fix strawberry-graphql union error. #1441) Resolve the incompatibility between Kedro-Viz and Kedro versions prior to 0.18.11. (Make Kedro-Viz compatible with previous Kedro with 'DataSet' #1445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Strawberry-graphql made a recent change to the way it handles strawberry.union. This change is considered breaking because users who have the latest kedro-viz but haven't updated their strawberry-graphql package will encounter the following error:
To fix this we have bumped strawberry-graphql dependency package to be at least version 0.192.
Development notes
QA notes
Checklist
RELEASE.mdfile