Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use calture-Info instead of language id in translate. #293

Merged

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Dec 8, 2020

Use calture-Info instead of language id in translate.

What's add in this pr :

  • Replace all BeatmapSetOnlineLanguage into CultureInfo
  • Test case still pass, happy.

In fa9d93a, need to fix:

And what's need to be added:

@andy840119
Copy link
Member Author

andy840119 commented Dec 9, 2020

Maybe wait until #283 has been implemented?
It might less broken time in master.

@andy840119
Copy link
Member Author

Seems need to merge before #296

@andy840119 andy840119 merged commit 36f183f into karaoke-dev:master Dec 10, 2020
@andy840119 andy840119 deleted the translate/calture-info-instead-of-num branch December 10, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant