Skip to content

Commit

Permalink
Comment out some code and need to give it a fix.
Browse files Browse the repository at this point in the history
  • Loading branch information
andy840119 committed Dec 8, 2020
1 parent cc8a201 commit fa9d93a
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

namespace osu.Game.Rulesets.Karaoke.Tests.Edit
{
/*
public class TestSceneManageLanguagesDialog : OsuManualInputManagerTestScene
{
protected override Container<Drawable> Content { get; } = new Container { RelativeSizeAxes = Axes.Both };
Expand Down Expand Up @@ -57,4 +58,5 @@ public void SetUpSteps()
AddStep("show dialog", () => dialog.Show());
}
}
*/
}
5 changes: 3 additions & 2 deletions osu.Game.Rulesets.Karaoke.Tests/Skinning/TestSceneLyric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ private Drawable testSingle(bool auto = false, double timeOffset = 0)
},
};

lyric.Translates.Add(0, "karaoke");
lyric.ApplyDisplayTranslate(0);
// todo : might add translate
//lyric.Translates.Add(0, "karaoke");
//lyric.ApplyDisplayTranslate(0);

lyric.ApplyDefaults(new ControlPointInfo(), new BeatmapDifficulty());

Expand Down
7 changes: 5 additions & 2 deletions osu.Game.Rulesets.Karaoke/Edit/Layout/PreviewSection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,11 @@ private Lyric createDefaultLyric(string text, string[] ruby, string[] romaji, st
// Apply property
lyric.StartTime = startTime;
lyric.Duration = duration;
lyric.Translates.Add(0, translate);
lyric.ApplyDisplayTranslate(0);

// todo : implementation
//lyric.Translates.Add(0, translate);
//lyric.ApplyDisplayTranslate(0);

lyric.TimeTags = TimeTagsUtils.ToTimeTagList(new Dictionary<TimeTagIndex, double>
{
{ new TimeTagIndex(0), startTime },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

namespace osu.Game.Rulesets.Karaoke.Edit.Translate.Components
{
// todo : move to other place
/*
public class DeleteLanguageDialog : PopupDialog
{
public DeleteLanguageDialog(BeatmapSetOnlineLanguage language, Action deleteAction)
Expand All @@ -35,4 +37,5 @@ public DeleteLanguageDialog(BeatmapSetOnlineLanguage language, Action deleteActi
};
}
}
*/
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace osu.Game.Rulesets.Karaoke.Edit.Translate.Components
{
// todo : move to other place
/*
public class DrawableLanguageList : OsuRearrangeableListContainer<BeatmapSetOnlineLanguage>
{
private Scroll scroll;
Expand Down Expand Up @@ -117,4 +119,5 @@ protected override void LoadComplete()
}
}
}
*/
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

namespace osu.Game.Rulesets.Karaoke.Edit.Translate.Components
{
// todo : move to other place
/*
public class DrawableLanguageListItem : OsuRearrangeableListItem<BeatmapSetOnlineLanguage>
{
private const float item_height = 35;
Expand Down Expand Up @@ -236,4 +238,5 @@ protected override bool OnClick(ClickEvent e)
}
}
}
*/
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

namespace osu.Game.Rulesets.Karaoke.Edit.Translate.Components
{
// todo : move to other place
/*
public class ManageLanguagesDialog : TitleFocusedOverlayContainer
{
protected override string Title => "Manage translates";
Expand All @@ -33,4 +35,5 @@ private void load(TranslateManager translateManager)
};
}
}
*/
}
3 changes: 2 additions & 1 deletion osu.Game.Rulesets.Karaoke/UI/LyricPlayfield.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ private void updateLyricTranslate()

if (isTranslate && targetTranslateLanguage != null)
{
lyrics.ForEach(x => x.ApplyDisplayTranslate(targetTranslateLanguage.Id));
// todo : apply language
// lyrics.ForEach(x => x.ApplyDisplayTranslate(targetTranslateLanguage.Id));
}
}

Expand Down

0 comments on commit fa9d93a

Please sign in to comment.