Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording default language as CultureInfo in config manager. #294

Closed
andy840119 opened this issue Dec 9, 2020 · 2 comments
Closed

Recording default language as CultureInfo in config manager. #294

andy840119 opened this issue Dec 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

Because in #293 changes translate language recording object from Object(And use it's language code as comparing prefer language) to CultureInfo.

So might need to deal the case :

config.GetBindable<CultureInfo>(KaraokeRulesetSetting.PreferLanguage)

Need to think about how to deal with save/load from database.
@andy840119 andy840119 added the bug Something isn't working label Dec 9, 2020
@andy840119
Copy link
Member Author

andy840119 commented Dec 9, 2020 •
edited
Loading

This issue can wait until #283 because now PreferLanguage is not working.

This was referenced Dec 9, 2020
Closed
Merged
Merged
@andy840119
Copy link
Member Author

This issue can be closed due to implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119