Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access from remote hosts #293

Closed
kevin-bates opened this issue Jul 17, 2018 · 2 comments
Closed

Allow access from remote hosts #293

kevin-bates opened this issue Jul 17, 2018 · 2 comments
Assignees

Comments

@kevin-bates
Copy link
Member

As of Notebook PR 3714 access from non-local hosts is being denied by default. Since this is the primary functionality provided by Kernel Gateway, we should always enable the ability to provide access from remote hosts. (The same change was required in Enterprise Gateway.)

@kevin-bates kevin-bates self-assigned this Jul 17, 2018
kevin-bates added a commit to kevin-bates/kernel_gateway that referenced this issue Jul 17, 2018
A recent change to Notebook (5.6.0) prevents access from remote hosts by default.
This change unconditionally re-enables that ability since remote access is a primary
tenet of Kernel Gateway.

Fixes jupyter-server#293
kevin-bates added a commit to kevin-bates/kernel_gateway that referenced this issue Jul 17, 2018
A recent change to Notebook (5.6.0) prevents access from remote hosts by default.
This change unconditionally re-enables that ability since remote access is a primary
tenet of Kernel Gateway.

Also dropped python 3.3 from the travis matrix since setuptools no longer supports
it (as of May 24) and was generating a failure during the installation phase.

Fixes jupyter-server#293
@rolweber
Copy link
Contributor

The PR also removed Python 3.3 from the Travis CI configuration. I don't remember whether removing support for Python 3.3 was already discussed, but I'm all for it :-)

@kevin-bates
Copy link
Member Author

Shoot - I'm sorry, I meant to include something like the following...

I've removed 3.3 from the Travis config since pkg_resources (via setuptools) no longer supports Python 3.3. That update was merged late May and delivered in release 40.0.0 July 8th.

$ python --version
Python 3.3.6
$ pip --version
pip 8.1.2 from /home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages (python 3.3)
install.1
4.07s$ pip install --upgrade setuptools pip
Collecting setuptools
  Downloading https://files.pythonhosted.org/packages/ff/f4/385715ccc461885f3cedf57a41ae3c12b5fec3f35cce4c8706b1a112a133/setuptools-40.0.0-py2.py3-none-any.whl (567kB)
    100% |████████████████████████████████| 573kB 452kB/s 
Collecting pip
  Downloading https://files.pythonhosted.org/packages/0f/74/ecd13431bcc456ed390b44c8a6e917c1820365cbebcb6a8974d1cd045ab4/pip-10.0.1-py2.py3-none-any.whl (1.3MB)
    100% |████████████████████████████████| 1.3MB 1.1MB/s 
Installing collected packages: setuptools, pip
  Found existing installation: setuptools 18.0.1
    Uninstalling setuptools-18.0.1:
      Successfully uninstalled setuptools-18.0.1
  Found existing installation: pip 8.1.2
    Uninstalling pip-8.1.2:
      Successfully uninstalled pip-8.1.2
Successfully installed pip-7.1.2 setuptools-40.0.0
0.18s$ python setup.py bdist_wheel sdist
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    from setuptools import setup
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/setuptools/__init__.py", line 12, in <module>
    import setuptools.version
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/setuptools/version.py", line 1, in <module>
    import pkg_resources
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/pkg_resources/__init__.py", line 85, in <module>
    raise RuntimeError("Python 3.4 or later is required")
RuntimeError: Python 3.4 or later is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants