-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access from remote hosts #294
Allow access from remote hosts #294
Conversation
A recent change to Notebook (5.6.0) prevents access from remote hosts by default. This change unconditionally re-enables that ability since remote access is a primary tenet of Kernel Gateway. Also dropped python 3.3 from the travis matrix since setuptools no longer supports it (as of May 24) and was generating a failure during the installation phase. Fixes jupyter-server#293
72b8248
to
97c13e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Was this an issue in release 2.0.2? KG prevents me from accessing from a remote host, even when i set NotebookApp.allow_remote_access to true. |
This is purely a function of the underlying Notebook release. What is the nature of the your issues? |
I'm running JKG in a container with port 8888 forwarded through to my localhost. When I try and connect to it from my client using an HTTP GET request for /api/kernelspecs it returns a 403 forbidden. The log says something like Access from remote host forbidden. Set NotebookApp.allow_remote_access to allow access. The kernelgateway variable allow_origins is set to '*'. I'll put an exact copy of the log up in a few minutes. I've broken my dockerfile while trying to debug this and am rebuilding it now. Also, would switching to Enterprise Gateway fix this? It looks like that might be something I'm going to do in the near future anyways because I would like my program to be able to run kernels on our HPCs. |
hmm - I can run Since this appears to be unrelated to this PR, I would suggest opening a new issue where proper discussion (and additional support) can take place. Thanks. |
Until there's a release of KG with this change, the problem will continue to occur for users who install KG since the notebook dependency is listed as |
I'm sorry @bashterm - I must have had a complete brain freeze. I was under the impression you were already running the JKG tip. So, if you're not on the tip and are running Notebook >= 5.6.0, then yes, @parente is correct, you need the latest JKG (and we should build a release). Especially since NB 5.6.0 was pushed out to address a security issue. Of course, your workaround is to downgrade NB < 5.6.0, but that's probably a function of the kind of environment you're dealing with. Regarding your question about Enterprise Gateway, yes, our 0.9.4 release has the fix. You should be able to install and run like JKG - then you can begin exploring the remote kernel capabilities. We hope to have our 1.0 release by JupyterCon. |
Ok. I have a lot of questions about Enterprise gateway. Should I just open an issue regarding them over on the GitHub for the Enterprise Gateway project? |
Yes, please. |
A recent change to Notebook (5.6.0) prevents access from remote hosts by default.
This change unconditionally re-enables that ability since remote access is a primary
tenet of Kernel Gateway.
Fixes #293