Allow access from remote hosts #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update to Notebook 5.6.0 has code that prevents remote host access. Since the entire purpose of Enterprise Gateway is to allow remote host access, we need to enable the web setting `allow_remote_access` to prevent the 403 exception. Added a statement to update the jupyter framework files after finding issues due to older dependencies. Also increased the timeout for waiting for the docker image startup from 30 to 60 seconds and added the ability to override on the command line using `PREP_TIMEOUT=n`.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebook PR 3714 in 5.6.0 has code that prevents remote host access. Since
the entire purpose of Enterprise Gateway is to allow remote host access, we need
to enable the web setting
allow_remote_accessto prevent the 403 exception.This was discovered due to recent Travis build failures since it uses updated resources.
This led to other dependency related issues, namely in the docker image used for
testing leading to the update of the jupyter framework files in the
Dockerfile.Also increased the timeout for waiting for the docker image startup from 30
to 60 seconds and added the ability to override on the command line using
PREP_TIMEOUT=n.