Adding support for objectRestSpread within props

[jnwng]

We hit at an issue properly parsing props that looked like

<div foo={{ params: {...router.params}}} />

because the SpreadProperty doesn't have a key/value pair. Opting to ignore spread properties, but properly recurse over the key/values we can parse.

[ljharb]

Seems reasonable

[coveralls]

Coverage increased (+0.02%) to 98.844% when pulling a5b9461 on jnwng:jw/fix-spread-property into e4c0312 on evcohen:master.

[coveralls]

Coverage increased (+0.02%) to 98.844% when pulling a5b9461 on jnwng:jw/fix-spread-property into e4c0312 on evcohen:master.

[beefancohen]

LGTM, thanks for fixing this!

[coveralls]

Coverage increased (+0.02%) to 98.844% when pulling 26d15ea on jnwng:jw/fix-spread-property into e4c0312 on evcohen:master.

[coveralls]

Coverage increased (+0.02%) to 98.844% when pulling 2eefda3 on jnwng:jw/fix-spread-property into e4c0312 on evcohen:master.

[jnwng]

@evcohen @ljharb thanks for the quick review! as an FYI, this was an issue because eslint-plugin-jsx-a11y is 1) stuck in npm with a dependency on [email protected] (not sure what happened there, the code in master is fine and 2) the objectRestSpread errors coming from that.

when this gets merged, would it be possible to bump eslint-plugin-jsx-a11y too? here's the pull request for that one

thank you so much!

[shanecav84]

@ljharb When can this be merged and released? It fixes #69.

[shanecav84]

@ljharb Thanks for getting this merged! What's the timeline for a release?

[ljharb]

That's up to @evcohen; i don't have publish rights nor am I familiar with the release procedure for this project.

[shanecav84]

@evcohen When can we get a new release with this PR?

[beefancohen]

Can work on that this weekend! thanks for your patience 😄

[shanecav84]

Thanks!