Adding support for objectRestSpread within props

jsx-eslint · Dec 6, 2017 · a5b9461 · a5b9461
1 parent e4c0312
commit a5b9461
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/__tests__/helper.js b/__tests__/helper.js
@@ -4,7 +4,7 @@ const parser = require('babylon');
 
 function parse(code) {
   return parser.parse(code, {
-    plugins: ['jsx', 'functionBind', 'estree'],
+    plugins: ['jsx', 'functionBind', 'estree', 'objectRestSpread'],
   });
 }
 

diff --git a/__tests__/src/getPropValue-test.js b/__tests__/src/getPropValue-test.js
@@ -768,6 +768,15 @@ describe('getPropValue', () => {
 
       assert.deepEqual(expected, actual);
     });
+
+    it('should evaluate to a correct representation of the object, ignore spread properties', () => {
+      const prop = extractProp('<div foo={{bar: "baz", ...{baz: "bar", foo: {...{bar: "meh"}}}}} />');
+
+      const expected = { bar: 'baz', baz: 'bar', foo: { bar: 'meh' } };
+      const actual = getPropValue(prop);
+
+      assert.deepEqual(expected, actual);
+    });
   });
 
   describe('New expression', () => {

diff --git a/src/values/expressions/ObjectExpression.js b/src/values/expressions/ObjectExpression.js
@@ -9,7 +9,13 @@ import getValue from './index';
 export default function extractValueFromObjectExpression(value) {
   return value.properties.reduce((obj, property) => {
     const object = Object.assign({}, obj);
-    object[getValue(property.key)] = getValue(property.value);
+    if (property.type === 'SpreadProperty') {
+      if (property.argument.type === 'ObjectExpression') {
+        return Object.assign(object, extractValueFromObjectExpression(property.argument));
+      }
+    } else {
+      object[getValue(property.key)] = getValue(property.value);
+    }
     return object;
   }, {});
 }