Bumping jsx-ast-utils to enable objectRestSpread
#363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 8, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "eslint-plugin-jsx-a11y", | |||
| "version": "6.0.2", | |||
| "version": "6.0.3", | |||
There was a problem hiding this comment.
please revert this; package versions should never be bumped in PRs.
|
LGTM, but this can't pass until v2.0.2 is available. Separately, it's not necessary because |
|
Just wanted to get a change in to make sure that a new version of
`eslint-plugin-jsx-a11y` gets into npm, so whichever way does it (bumping
this version, or just publishing a new release) works for me!
…On Thu, Dec 7, 2017 at 4:27 PM Jordan Harband ***@***.***> wrote:
LGTM, but this can't pass until v2.0.2 is available.
Separately, it's not necessary because ^2.0.0 automatically includes
v2.0.2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/363#issuecomment-350136259>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABERRnxP__9QXG1ShXibXXfuXVyll30Dks5s-IJcgaJpZM4Q537d>
.
|
|
This should come for free now that v6.0.3 is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the requisite bump in
jsx-ast-utilsto enableobjectRestSpread.This should address #327 and close https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/356 when published — for some reason the
package.jsonshowing foreslint-plugin-jsx-a11yin NPM hasjsx-ast-utils@^1.4.0but should be^2.0.0.